Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fix unprefixed i18n identifiers in examples #8477

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[Backport 2.x] Fix unprefixed i18n identifiers in examples #8477

merged 1 commit into from
Oct 4, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2f541ff from #8412.

@github-actions @opensearch-changeset-bot
Fix unprefixed i18n identifiers in examples (#8412)
be0ab4d 
* Fix unprefixed and duplicate i18n identifiers in examples

Signed-off-by: Miki <[email protected]>

* Changeset file for PR #8412 created/updated

* Changeset file for PR #8412 created/updated

* Changeset file for PR #8412 created/updated

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2f541ff)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added i18n Internationalization related Issues and PRs autocut Skip the changelog verification check on backports distinguished-contributor v2.18.0 labels Oct 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.04%. Comparing base (47ce1fd) to head (be0ab4d).
Report is 11 commits behind head on 2.x.

Files with missing lines Patch % Lines
...es/public/list_container/list_container_factory.ts 0.00% 1 Missing ⚠️
...amples/public/todo/todo_ref_embeddable_factory.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              2.x    #8477   +/-   ##
=======================================
  Coverage   61.04%   61.04%           
=======================================
  Files        3757     3757           
  Lines       89319    89319           
  Branches    13964    13964           
=======================================
  Hits        54524    54524           
  Misses      31406    31406           
  Partials     3389     3389
Flag Coverage Δ
Linux_1 28.93% <ø> (ø)
Linux_2 56.47% <ø> (ø)
Linux_3 37.81% <ø> (ø)
Linux_4 30.08% <0.00%> (ø)
Windows_1 28.94% <ø> (ø)
Windows_2 56.42% <ø> (ø)
Windows_3 37.82% <ø> (ø)
Windows_4 30.08% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 3fb549d into 2.x Oct 4, 2024
67 of 70 checks passed
@github-actions github-actions bot deleted the backport/backport-8412-to-2.x branch October 4, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports distinguished-contributor failed changeset i18n Internationalization related Issues and PRs v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruanyl @AMoo-Miki