Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dropdowns in issue templates to have no option selected by default #11805

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Jan 8, 2024

Description

Update required dropdowns in issue templates to have no option selected by default.
This change updates the bug and feature templates to set the first option as empty. This prevents form submission until an option is selected.

This wasn't all that intuitive, see https://github.com/orgs/community/discussions/61648, but workaround here is to set the first option to empty.

See my fork to test this behavior out - https://github.com/mch2/OpenSearch/issues/new/choose The form cannot be submit until a value is selected.

Related Issues

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ault

This change updates the bug and feature templates to set the first option as empty.
This prevents form submission until an option is selected.

Signed-off-by: Marc Handalian <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Compatibility status:

Checks if related components are compatible with change adf0d6e

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

github-actions bot commented Jan 8, 2024

❌ Gradle check result for adf0d6e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mch2
Copy link
Member Author

mch2 commented Jan 8, 2024

❌ Gradle check result for adf0d6e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#1703

@deshsidd
Copy link
Contributor

deshsidd commented Jan 8, 2024

LGTM

Copy link
Contributor

github-actions bot commented Jan 8, 2024

❕ Gradle check result for adf0d6e: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.multipart.RemoteStoreMultipartIT.testNoSearchIdleForAnyReplicaCount

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@mch2 mch2 merged commit 0b30f30 into opensearch-project:main Jan 8, 2024
40 of 42 checks passed
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…ault (opensearch-project#11805)

This change updates the bug and feature templates to set the first option as empty.
This prevents form submission until an option is selected.

Signed-off-by: Marc Handalian <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ault (opensearch-project#11805)

This change updates the bug and feature templates to set the first option as empty.
This prevents form submission until an option is selected.

Signed-off-by: Marc Handalian <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants