Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] Extract cluster management for integration tests into JUnit test rule out of OpenSearchIntegTestCase (#11877) #11941

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Jan 18, 2024

Backport of #11877 to 2.x

… out of OpenSearchIntegTestCase (opensearch-project#11877)

* Extract cluster management for integration tests into JUnit test rule out of OpenSearchIntegTestCase

Signed-off-by: Andriy Redko <[email protected]>

* Branched off parametrized tests into static / dynamic settings flavors

Signed-off-by: Andriy Redko <[email protected]>

* Address code review comments

Signed-off-by: Andriy Redko <[email protected]>

* Refactor internalCluster() method to return an Optional value

Signed-off-by: Andriy Redko <[email protected]>

* Address code review comments

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit c267c5a)
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 0b8bcf7

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security.git]

Copy link
Contributor

❌ Gradle check result for 0b8bcf7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented Jan 18, 2024

❌ Gradle check result for 0b8bcf7: FAILURE

#10006
#8947

Copy link
Contributor

❌ Gradle check result for 0b8bcf7:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 0b8bcf7: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit
      1 org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads
      1 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a2eb7f2) 70.77% compared to head (0b8bcf7) 71.09%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11941      +/-   ##
============================================
+ Coverage     70.77%   71.09%   +0.32%     
- Complexity    59023    59373     +350     
============================================
  Files          4891     4891              
  Lines        279915   279915              
  Branches      41050    41050              
============================================
+ Hits         198105   199018     +913     
+ Misses        65001    64015     -986     
- Partials      16809    16882      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 0d12779 into opensearch-project:2.x Jan 19, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants