Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Concurrent Segment Search feature flags for feature launch #12074

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented Jan 29, 2024

Description

Remove concurrent segment search feature flag. Included related changes are as follows:

  • Remove featureFlagSettings() override from all affected *IT.java classes
  • Update the cat.shards and cat.thread_pool rest-api-spec tests. Some are still failing due to bwc and need this change to be backported.
  • Change concurrent segment search cluster setting default to false.
  • Change SettingsModuleTests.java related to concurrent segment search feature flag.
  • Change SearchModuleTests.java related to concurrent segment search feature flag.
  • Change SearchServiceTests.java related to concurrent segment search feature flag.
  • Fix RestShardsActionTests.java

Related Issues

Resolves #9100

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added distributed framework enhancement Enhancement or improvement to existing feature or request labels Jan 29, 2024
Copy link
Contributor

❌ Gradle check result for 78e05b6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2f69ad0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Compatibility status:

Checks if related components are compatible with change 69c742f

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git]

Copy link
Contributor

❌ Gradle check result for f77f40e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for b18ee7d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 802284b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7e9741c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jed326 jed326 added backport 2.x Backport to 2.x branch v2.12.0 Issues and PRs related to version 2.12.0 labels Jan 31, 2024
@jed326 jed326 marked this pull request as ready for review January 31, 2024 17:50
@jed326
Copy link
Collaborator Author

jed326 commented Feb 2, 2024

  • we won't fail with "unknown feature flag" right?

I think this must be the case, otherwise the Mixed cluster client tests would be failing. @andrross I know you have experience with removing feature flags from searchable snapshots, do you have anything else to add here?

@andrross
Copy link
Member

andrross commented Feb 2, 2024

@jed326 The feature flag should be removed from the default configuration file as well: https://github.com/opensearch-project/OpenSearch/blob/main/distribution/src/config/opensearch.yml#L118-L123

@jed326
Copy link
Collaborator Author

jed326 commented Feb 2, 2024

@jed326 The feature flag should be removed from the default configuration file as well: https://github.com/opensearch-project/OpenSearch/blob/main/distribution/src/config/opensearch.yml#L118-L123

@andrross I just realized the same...already pushed a commit to remove :)

Copy link
Contributor

github-actions bot commented Feb 2, 2024

❌ Gradle check result for 7c521dc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 2, 2024

❌ Gradle check result for a0e3b47: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jed326
Copy link
Collaborator Author

jed326 commented Feb 2, 2024

@andrross @reta created a new issue for improving feature flag management: #12150

Copy link
Contributor

github-actions bot commented Feb 2, 2024

✅ Gradle check result for 69c742f: SUCCESS

@reta
Copy link
Collaborator

reta commented Feb 2, 2024

@andrross @ticheng-aws what do you think folks?

@ticheng-aws
Copy link
Contributor

@andrross @ticheng-aws what do you think folks?

LGTM, thanks @jed326.

@andrross andrross merged commit 26a66f0 into opensearch-project:main Feb 2, 2024
31 of 35 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12074-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 26a66f0749164f3c988ea228ac3913eb9e81e9c3
# Push it to GitHub
git push --set-upstream origin backport/backport-12074-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12074-to-2.x.

@jed326
Copy link
Collaborator Author

jed326 commented Feb 2, 2024

Thanks @andrross! Will do the 2.x PR and main bwc PR shortly.

jed326 added a commit to jed326/OpenSearch that referenced this pull request Feb 2, 2024
andrross pushed a commit that referenced this pull request Feb 3, 2024
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
@jed326 jed326 deleted the ga-launch branch March 12, 2024 22:13
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed distributed framework enhancement Enhancement or improvement to existing feature or request v2.12.0 Issues and PRs related to version 2.12.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Concurrent Segment Search][Meta] GA readiness items
5 participants