-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix (some) AzureBlobContainerRetriesTests flaky tests #15184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Redko <[email protected]>
reta
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
August 9, 2024 16:27
github-actions
bot
added
>test-failure
Test failure from CI, local build, etc.
autocut
flaky-test
Random test failure that succeeds on second run
Storage:Snapshots
labels
Aug 9, 2024
❕ Gradle check result for f2c1e26: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15184 +/- ##
============================================
- Coverage 71.91% 71.84% -0.07%
+ Complexity 63016 63003 -13
============================================
Files 5185 5185
Lines 295183 295183
Branches 42663 42663
============================================
- Hits 212279 212077 -202
- Misses 65461 65643 +182
- Partials 17443 17463 +20 ☔ View full report in Codecov by Sentry. |
mch2
approved these changes
Aug 9, 2024
reta
changed the title
Fix (some_ AzureBlobContainerRetriesTests flaky tests
Fix (some) AzureBlobContainerRetriesTests flaky tests
Aug 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
(cherry picked from commit 3b358e3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Aug 9, 2024
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Aug 20, 2024
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autocut
backport 2.x
Backport to 2.x branch
flaky-test
Random test failure that succeeds on second run
skip-changelog
Storage:Snapshots
>test-failure
Test failure from CI, local build, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems like the timeout of 2 seconds was quite aggressive, bumping it to 5 seconds.
Related Issues
Closes #14318
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.