Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add Create QueryGroup API Logic (#14680) #15227

Merged

Conversation

jainankitk
Copy link
Collaborator

Backports #14680

* add logic for Create QueryGroup API
Signed-off-by: Ruirui Zhang <[email protected]>

* remove wildcard imports
Signed-off-by: Ruirui Zhang <[email protected]>

* change jvm to memeory
Signed-off-by: Ruirui Zhang <[email protected]>

* modify querygroup
Signed-off-by: Ruirui Zhang <[email protected]>

* fix javadoc and add more tests
Signed-off-by: Ruirui Zhang <[email protected]>

* add more tests
Signed-off-by: Ruirui Zhang <[email protected]>

* address comments
Signed-off-by: Ruirui Zhang <[email protected]>

* fix the persist logic
Signed-off-by: Ruirui Zhang <[email protected]>

* remove inflight checks as they are not necessary
Signed-off-by: Ruirui Zhang <[email protected]>

* remove persistable interface
Signed-off-by: Ruirui Zhang <[email protected]>

* modify QueryGroupServiceSettings
Signed-off-by: Ruirui Zhang <[email protected]>

* add in an action package in the plugin
Signed-off-by: Ruirui Zhang <[email protected]>

* modify based on commments
Signed-off-by: Ruirui Zhang <[email protected]>

* address comments on QueryGroupPersistenceService
Signed-off-by: Ruirui Zhang <[email protected]>

* address comments on persistence service
Signed-off-by: Ruirui Zhang <[email protected]>

* address comments
Signed-off-by: Ruirui Zhang <[email protected]>

* fix unit test
Signed-off-by: Ruirui Zhang <[email protected]>

* address comments
Signed-off-by: Ruirui Zhang <[email protected]>

* add IT
Signed-off-by: Ruirui Zhang <[email protected]>

* add coverage
Signed-off-by: Ruirui Zhang <[email protected]>
(cherry picked from commit d442f7c)
Copy link
Contributor

✅ Gradle check result for 79a1cb5: SUCCESS

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 74.50980% with 39 lines in your changes missing coverage. Please review.

Project coverage is 71.56%. Comparing base (2e6c5de) to head (79a1cb5).
Report is 10 commits behind head on 2.x.

Files Patch % Lines
...va/org/opensearch/cluster/metadata/QueryGroup.java 75.55% 4 Missing and 7 partials ⚠️
...ch/plugin/wlm/rest/RestCreateQueryGroupAction.java 0.00% 8 Missing ⚠️
...in/wlm/action/TransportCreateQueryGroupAction.java 0.00% 7 Missing ⚠️
...pensearch/plugin/wlm/WorkloadManagementPlugin.java 0.00% 4 Missing ⚠️
...arch/plugin/wlm/action/CreateQueryGroupAction.java 0.00% 3 Missing ⚠️
...rch/plugin/wlm/action/CreateQueryGroupRequest.java 76.92% 3 Missing ⚠️
...ugin/wlm/service/QueryGroupPersistenceService.java 94.64% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15227      +/-   ##
============================================
+ Coverage     71.49%   71.56%   +0.06%     
- Complexity    62809    62835      +26     
============================================
  Files          5138     5145       +7     
  Lines        295078   295187     +109     
  Branches      42980    42989       +9     
============================================
+ Hits         210980   211260     +280     
+ Misses        66459    66195     -264     
- Partials      17639    17732      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jainankitk jainankitk mentioned this pull request Aug 16, 2024
8 tasks
@jed326 jed326 merged commit 1bee506 into opensearch-project:2.x Aug 16, 2024
55 of 56 checks passed
@jed326 jed326 changed the title Add Create QueryGroup API Logic (#14680) [Backport 2.x] Add Create QueryGroup API Logic (#14680) Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants