Add more unit tests for RemoteStoreUtils and RemoteFsTimestampAwareTranslog #16151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinpkale
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
sachinpkale
commented
Oct 1, 2024
server/src/main/java/org/opensearch/index/remote/RemoteStoreUtils.java
Outdated
Show resolved
Hide resolved
sachinpkale
commented
Oct 1, 2024
server/src/main/java/org/opensearch/index/translog/RemoteFsTimestampAwareTranslog.java
Show resolved
Hide resolved
|
❌ Gradle check result for 063f3fc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16151 +/- ##
============================================
- Coverage 71.87% 71.86% -0.01%
+ Complexity 64528 64509 -19
============================================
Files 5296 5296
Lines 301744 301746 +2
Branches 43585 43586 +1
============================================
- Hits 216864 216841 -23
- Misses 67014 67080 +66
+ Partials 17866 17825 -41 ☔ View full report in Codecov by Sentry. |
|
❌ Gradle check result for b42e759: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sachin Kale <[email protected]>
…mFromMetadataFile Signed-off-by: Sachin Kale <[email protected]>
…Remote Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
sachinpkale
force-pushed
the
pinned-timestamp-tests
branch
from
b42e759
to
a84b06a
Compare
gbbafna
approved these changes
Oct 4, 2024
|
❕ Gradle check result for a84b06a: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
…anslog (#16151) Signed-off-by: Sachin Kale <[email protected]> (cherry picked from commit aef7eca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale
pushed a commit
that referenced
this pull request
Oct 4, 2024
…anslog (#16151) (#16186) (cherry picked from commit aef7eca) Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.