Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Remove Identity FeatureFlag (#16024) #16157

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Oct 1, 2024

Manual backport of #16024 to 2.x that resolves conflicts in the CHANGELOG

* Remove Identity FeatureFlag

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Mark IdentityService as internal

Signed-off-by: Craig Perkins <[email protected]>

* Add @internalapi annotation

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 7b248ef)
Copy link
Contributor

github-actions bot commented Oct 1, 2024

❌ Gradle check result for d1a23bb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ Gradle check result for d1a23bb: SUCCESS

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.59%. Comparing base (20d32cf) to head (d1a23bb).
Report is 6 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16157      +/-   ##
============================================
- Coverage     71.60%   71.59%   -0.02%     
+ Complexity    64716    64682      -34     
============================================
  Files          5278     5278              
  Lines        302835   302873      +38     
  Branches      44059    44059              
============================================
- Hits         216848   216833      -15     
+ Misses        67932    67892      -40     
- Partials      18055    18148      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit f78e628 into opensearch-project:2.x Oct 1, 2024
58 checks passed
@reta reta added the v2.18.0 Issues and PRs related to version 2.18.0 label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.18.0 Issues and PRs related to version 2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants