Reconfigure remote state thread pool count #16245
Open
+2
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sooraj Sinha <[email protected]>
soosinha
requested review from
jed326,
peternied,
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 0ffa818: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Bukhtawar
reviewed
Oct 9, 2024
| return boundedBy((allocatedProcessors(settings) + 7) / 8, 1, 2); | ||
| return boundedBy((allocatedProcessors(settings) + 1) / 2, 1, 2); |
There was a problem hiding this comment.
sorry what does this change try to achieve for my understanding and is it used only on the context of remote publication
There was a problem hiding this comment.
With the previous formula (boundedBy((allocatedProcessors(settings) + 7) / 8, 1, 2)), the number of threads would be 2 when number of cores is 16 or more. For cores less than 1, number of threads would be 1.
With the new formula, the number of threads would be 2 when there are 4 cores or more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configuring the thread pool for remote state read and write in order to increase the thread count.
Related Issues
#16055
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.