Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default for EnginePlugin.getEngineFactory #2419

Merged
merged 3 commits into from
Mar 16, 2022
Merged

Add default for EnginePlugin.getEngineFactory #2419

merged 3 commits into from
Mar 16, 2022

Commits on Mar 9, 2022

  1. Add default for EnginePlugin.getEngineFactory 

    Adds default implementation for getEngineFactory in EnginePlugin. The
default just returns Optional.empty(), allowing plugin developers to
implement this plugin without implementing this method.

Signed-off-by: John Mazanec <[email protected]>
    @jmazanec15
    jmazanec15 committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    cc05bcc View commit details
    Browse the repository at this point in the history

  2. Add EnginePluginTests for getEngineFactory method 

    Signed-off-by: John Mazanec <[email protected]>
    @jmazanec15
    jmazanec15 committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    9e10d0e View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Move getEngineFactory test 

    Signed-off-by: John Mazanec <[email protected]>
    @jmazanec15
    jmazanec15 committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    98f2f5e View commit details
    Browse the repository at this point in the history