Added a new line linter

[owaiskazi19]

Description

Added a new-line linter to make sure all files end with a single newline. This is a POSIX standard, read more https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline. Thanks @peternied for introducing it.

Issues Resolved

#2857

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

❌   Gradle Check failure 92b274adf2dcd58e13827471cc7294ffb0649dad
Log 4410

Reports 4410

[opensearch-ci-bot]

❌   Gradle Check failure 7b6ed41b889be5f1a13af473ab85631c053309f8
Log 4411

Reports 4411

[peternied]

Nice!

[peternied]

I'd recommend renaming the file name to match the workflow name, new-line -> code-hygiene. In the future you could add addition jobs that scanned for other hygiene related issues.

[tlfeng]

In log 4411:

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.action.bulk.BulkRequestTests.testBulkTerminatedByNewline" -Dtests.seed=F8AC59B864ACF83D -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=zh-Hans-SG -Dtests.timezone=CTT -Druntime.java=17

org.opensearch.action.bulk.BulkRequestTests > testBulkTerminatedByNewline FAILED
    junit.framework.AssertionFailedError: Expected exception IllegalArgumentException but no exception was thrown
        at __randomizedtesting.SeedInfo.seed([F8AC59B864ACF83D:5C8957B388059622]:0)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2898)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2884)
        at org.opensearch.action.bulk.BulkRequestTests.testBulkTerminatedByNewline(BulkRequestTests.java:363)

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.action.search.MultiSearchRequestTests.testMsearchTerminatedByNewline" -Dtests.seed=F8AC59B864ACF83D -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sv -Dtests.timezone=America/Tegucigalpa -Druntime.java=17

org.opensearch.action.search.MultiSearchRequestTests > testMsearchTerminatedByNewline FAILED
    junit.framework.AssertionFailedError: Expected exception IllegalArgumentException but no exception was thrown
        at __randomizedtesting.SeedInfo.seed([F8AC59B864ACF83D:61D0ED2E2B325170]:0)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2898)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2884)
        at org.opensearch.action.search.MultiSearchRequestTests.testMsearchTerminatedByNewline(MultiSearchRequestTests.java:320)

> Task :rest-api-spec:yamlRestTest

REPRODUCE WITH: ./gradlew ':rest-api-spec:yamlRestTest' --tests "org.opensearch.test.rest.ClientYamlTestSuiteIT" -Dtests.method="test {p0=cluster.state/20_filtering/Filtering the cluster state returns cluster_uuid at the top level regardless of metric filters}" -Dtests.seed=F8AC59B864ACF83D -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=be-BY -Dtests.timezone=America/Glace_Bay -Druntime.java=17

org.opensearch.test.rest.ClientYamlTestSuiteIT > test {p0=cluster.state/20_filtering/Filtering the cluster state returns cluster_uuid at the top level regardless of metric filters} FAILED
    java.lang.AssertionError: Failure at [cluster.state/20_filtering:168]: got unexpected warning header [
    	299 OpenSearch-3.0.0-SNAPSHOT-b3af34c2171764a767dea668b6969b20434103db "Deprecated value [master_node] used for parameter [metric]. To promote inclusive language, please use [cluster_manager_node] instead. It will be unsupported in a future major version."
    ]
        at __randomizedtesting.SeedInfo.seed([F8AC59B864ACF83D:70F86662CA5095C5]:0)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.executeSection(OpenSearchClientYamlSuiteTestCase.java:451)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.test(OpenSearchClientYamlSuiteTestCase.java:424)

The last test failure is caused by a PR merged yesterday that changed the expected warning message by mistake in the commit 07fc06d (of PR #2678), which makes the deprecation warning is not the same as the expected in the test.

[opensearch-ci-bot]

❌   Gradle Check failure 94e63c7a15fbb7e10b06db3cae1386a3621f646e
Log 4412

Reports 4412

[opensearch-ci-bot]

❌   Gradle Check failure 4827228a2b6e274b98a0da5ff508962aaa26f638
Log 4413

Reports 4413

[opensearch-ci-bot]

✅   Gradle Check success c92d1b6
Log 4416

Reports 4416

[dblock]

@owaiskazi19 I'm not going to backport this into 2.0, I think we can let that one be

[owaiskazi19]

@owaiskazi19 I'm not going to backport this into 2.0, I think we can let that one be

Sounds good. Thanks for the review and taking care of the 2.x backport.