Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: Add condition to ensure data correctness on primary promotion #8431

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented Jul 4, 2023

Description

Add condition to ensure data correctness on primary promotion

Related Issues

Resolves #8059

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #8431 (ac50fb1) into main (64c0871) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8431      +/-   ##
============================================
- Coverage     70.92%   70.80%   -0.12%     
+ Complexity    56917    56893      -24     
============================================
  Files          4758     4758              
  Lines        269186   269186              
  Branches      39408    39408              
============================================
- Hits         190909   190601     -308     
- Misses        62134    62514     +380     
+ Partials      16143    16071      -72     

see 471 files with indirect coverage changes

@mch2 mch2 merged commit bcaf494 into opensearch-project:main Jul 6, 2023
11 of 36 checks passed
@mch2 mch2 added the backport 2.x Backport to 2.x branch label Jul 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 6, 2023
…tion (#8431)

Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit bcaf494)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Jul 6, 2023
…tion (#8431) (#8495)

(cherry picked from commit bcaf494)

Signed-off-by: Ankit Kala <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
2 participants