-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AUTO] Increment version to 1.3.14.0 #654
Conversation
opensearch-trigger-bot
bot
commented
Nov 24, 2023
- Incremented version to 1.3.14.0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.3 #654 +/- ##
=======================================
Coverage 45.94% 45.94%
=======================================
Files 150 150
Lines 4960 4960
Branches 971 958 -13
=======================================
Hits 2279 2279
Misses 2463 2463
Partials 218 218 ☔ View full report in Codecov by Sentry. |
Can we get another review for this version bump PR? Thanks! @ohltyler |
Line 7 of the package.json should be bumped as well, and there should be no yarn.lock file changes. Let me know if there is anything I can do on the automated PR logic to account for these changes, else these PRs provide no benefit to us still. |
@prudhvigodithi Could you help look into our auto version bump for dashboards as what Tyler suggested above? Not sure why |
The reason If there is a way to ignore yarn.lock changes in the version bump logic that would be ideal. Version bumps shouldn't have any impact on pulled in dependencies. |
Signed-off-by: opensearch-ci-bot <[email protected]>
fcf9fc1
to
4216aad
Compare
@ohltyler I will manually create PR for this repo this time and discuss with my team for future enhancement on this auto version increment logic. |
New PR raised here. #655 |
Thank you! I appreciate the quick action |