Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTO] Increment version to 1.3.14.0 #654

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

  • Incremented version to 1.3.14.0.

@opensearch-trigger-bot opensearch-trigger-bot bot added the v1.3.14 Issues targeting release v1.3.14 label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae1ec44) 45.94% compared to head (4216aad) 45.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##              1.3     #654   +/-   ##
=======================================
  Coverage   45.94%   45.94%           
=======================================
  Files         150      150           
  Lines        4960     4960           
  Branches      971      958   -13     
=======================================
  Hits         2279     2279           
  Misses       2463     2463           
  Partials      218      218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zelinh
zelinh previously approved these changes Nov 30, 2023
@zelinh
Copy link
Member

zelinh commented Nov 30, 2023

Can we get another review for this version bump PR? Thanks! @ohltyler

@ohltyler
Copy link
Member

Can we get another review for this version bump PR? Thanks! @ohltyler

Line 7 of the package.json should be bumped as well, and there should be no yarn.lock file changes. Let me know if there is anything I can do on the automated PR logic to account for these changes, else these PRs provide no benefit to us still.

@zelinh
Copy link
Member

zelinh commented Nov 30, 2023

@prudhvigodithi Could you help look into our auto version bump for dashboards as what Tyler suggested above? Not sure why yarn.lock file gets updated here, maybe you can provide more inputs. Thanks.

@ohltyler
Copy link
Member

ohltyler commented Nov 30, 2023

@prudhvigodithi Could you help look into our auto version bump for dashboards as what Tyler suggested above? Not sure why yarn.lock file gets updated here, maybe you can provide more inputs. Thanks.

The reason yarn.lock is updated is due to the fact it is getting re-generated without being in the context of core Dashboards. The stored yarn.lock we have, includes dependencies pulled in from core Dashboards. When running yarn.build in the standalone AD repo, it would produce this. We have the same problem with dependabot PRs due to this nested structure.

If there is a way to ignore yarn.lock changes in the version bump logic that would be ideal. Version bumps shouldn't have any impact on pulled in dependencies.

Signed-off-by: opensearch-ci-bot <[email protected]>
@zelinh
Copy link
Member

zelinh commented Dec 1, 2023

@ohltyler I will manually create PR for this repo this time and discuss with my team for future enhancement on this auto version increment logic.

@zelinh
Copy link
Member

zelinh commented Dec 1, 2023

New PR raised here. #655

@ohltyler
Copy link
Member

ohltyler commented Dec 1, 2023

New PR raised here. #655

Thank you! I appreciate the quick action

@ohltyler ohltyler closed this Dec 1, 2023
@ohltyler ohltyler deleted the create-pull-request/1.3.14.0 branch December 1, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.3.14 Issues targeting release v1.3.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants