update create detector page and detector detail page to add custom result index lifecycle management settings #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jackie Han <[email protected]>
…sult index lifecycle management settings Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: Jackie Han <[email protected]>
jackiehanyang
requested review from
ohltyler,
kaituo,
amitgalitz,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
==========================================
+ Coverage 50.31% 50.99% +0.68%
==========================================
Files 166 166
Lines 5595 5963 +368
Branches 1075 1202 +127
==========================================
+ Hits 2815 3041 +226
- Misses 2508 2564 +56
- Partials 272 358 +86 ☔ View full report in Codecov by Sentry. |
kaituo
reviewed
Jun 5, 2024
public/pages/DefineDetector/components/CustomResultIndex/CustomResultIndex.tsx
Outdated
Show resolved
Hide resolved
public/pages/ReviewAndCreate/components/DetectorDefinitionFields/DetectorDefinitionFields.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Jackie Han <[email protected]>
kaituo
approved these changes
Jun 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
…sult index lifecycle management settings (#770) * add custom result index lifecycle management conditions Signed-off-by: Jackie Han <[email protected]> * update create detector page and detector detail page to add custom result index lifecycle management settings Signed-off-by: Jackie Han <[email protected]> * code formatting update Signed-off-by: Jackie Han <[email protected]> * add more tests Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit 1080d60)
jackiehanyang
added a commit
that referenced
this pull request
Jun 5, 2024
…sult index lifecycle management settings (#770) (#771) * add custom result index lifecycle management conditions Signed-off-by: Jackie Han <[email protected]> * update create detector page and detector detail page to add custom result index lifecycle management settings Signed-off-by: Jackie Han <[email protected]> * code formatting update Signed-off-by: Jackie Han <[email protected]> * add more tests Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit 1080d60) Co-authored-by: Jackie Han <[email protected]>
This was referenced Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update create detector page and detector detail page to add custom result index lifecycle management settings
Screen.Recording.2024-06-05.at.14.16.43.mov
Issues Resolved
opensearch-project/anomaly-detection#1213
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.