Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace references to deleted BaseNodeRequest with TransportRequest #688

Closed

Conversation

dbwiddis
Copy link
Member

Signed-off-by: Daniel Widdis [email protected]

Description

#4702 removed the (deprecated) BaseNodeRequest class.

Per the @deprecated tag in the javadocs of the removed class, subclasses should extend TransportRequest directly.

Issues Resolved

Fixes #687

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler
Copy link
Member

Fixed in #696 , thanks.

@ohltyler ohltyler closed this Oct 21, 2022
@dbwiddis dbwiddis deleted the base-node-request-removed branch October 24, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AD doesn't compile: BaseNodeRequest class has been removed
2 participants