Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling docrep to remote store migration test for integTestRemote #1379

Merged
merged 1 commit into from
May 3, 2024

Conversation

astute-decipher
Copy link
Contributor

@astute-decipher astute-decipher commented May 2, 2024

Description

Disabling docrep to remote store migration test for integTestRemote suite, since it's failing to pass opensearch.experimental.feature.remote_store.migration.enabled feature flag.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@ankitkala ankitkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks okay to me. How did we verify that integTestRemote is excluding this test method?

@astute-decipher
Copy link
Contributor Author

astute-decipher commented May 2, 2024

Change looks okay to me. How did we verify that integTestRemote is excluding this test method?

While running the individual test :
./gradlew ':integTestRemote' --tests "org.opensearch.replication.integ.rest.StartReplicationIT.test operations are fetched from lucene when leader is in mixed mode"

it fails with error :

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':integTestRemote'.
> No tests found for given includes: [**/*IT.class](include rules) [**/*$*.class](exclude rules) [org.opensearch.replication.integ.rest.StartReplicationIT.test operations are fetched from lucene when leader is in mixed mode](--tests filter)

Whereas we don't see this error, before the change. cc : @ankitkala

@nisgoel-amazon
Copy link
Contributor

We can also run the integTestRemote complete suite by creating 2 clusters using docker and by passing the appropriate parameter

./gradlew integTestRemote -Dleader.http_host=172.18.0.2:9200 -Dfollower.http_host=172.18.0.3:9201 -Dfollower.transport_host=172.18.0.3:9301  -Dleader.transport_host=172.18.0.2:9300  -Dsecurity_enabled=false -Duser=admin -Dpassword=<Password of host> -PnumNodes=1 

@monusingh-1 monusingh-1 merged commit d287aa2 into opensearch-project:main May 3, 2024
14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2024
…1379)

Signed-off-by: Shubh Sahu <[email protected]>
Co-authored-by: Shubh Sahu <[email protected]>
(cherry picked from commit d287aa2)
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2024
…1379)

Signed-off-by: Shubh Sahu <[email protected]>
Co-authored-by: Shubh Sahu <[email protected]>
(cherry picked from commit d287aa2)
monusingh-1 pushed a commit that referenced this pull request May 3, 2024
…1379) (#1381)

Signed-off-by: Shubh Sahu <[email protected]>
Co-authored-by: Shubh Sahu <[email protected]>
(cherry picked from commit d287aa2)

Co-authored-by: Shubh Sahu <[email protected]>
monusingh-1 pushed a commit that referenced this pull request May 3, 2024
…1379) (#1382)

Signed-off-by: Shubh Sahu <[email protected]>
Co-authored-by: Shubh Sahu <[email protected]>
(cherry picked from commit d287aa2)

Co-authored-by: Shubh Sahu <[email protected]>
skumarp7 pushed a commit to nokia/opensearch-project-cross-cluster-replication that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants