Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of context aware alert analysis #215

Merged
merged 13 commits into from
Jul 31, 2024
Merged

Initial implementation of context aware alert analysis #215

merged 13 commits into from
Jul 31, 2024

Conversation

songkant-aws
Copy link
Contributor

@songkant-aws songkant-aws commented Jul 12, 2024 •
edited
Loading

Description

Initial context aware alert analysis implementation in assistant dashboard by leveraging existing IncontextInsight 'GeneratePopover' component

Issues Resolved

[Issue #214 ]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@wanglam
Copy link
Collaborator

wanglam commented Jul 12, 2024

@songkant-aws Is this PR target for 2.16?

wanglam
wanglam reviewed Jul 12, 2024
View reviewed changes
common/types/chat_saved_object_attributes.ts Outdated Show resolved Hide resolved
server/services/chat/olly_chat_service.ts Outdated Show resolved Hide resolved
server/routes/chat_routes.ts Show resolved Hide resolved
@songkant-aws
Copy link
Contributor Author

songkant-aws commented Jul 16, 2024 •
edited
Loading

@songkant-aws Is this PR target for 2.16?

Yes, the PR is targeting for 2.16 @wanglam

@wanglam wanglam added v2.16.0 backport 2.x Trigger the backport flow to 2.x labels Jul 16, 2024
wanglam
wanglam approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@wanglam wanglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM!

Hailong-am
Hailong-am approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@Hailong-am Hailong-am left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems there has a conflict for changelog file

@songkant-aws
Copy link
Contributor Author

seems there has a conflict for changelog file

Resolved changelog conflict

@raintygao
Copy link
Collaborator

seems there has a conflict for changelog file

Resolved changelog conflict

@songkant-aws Should this PR be merged in 2.16? If so, I suppose we should add a label and update release notes.

@songkant-aws
Copy link
Contributor Author

@raintygao As far as I know, it's not required to be merged in 2.16.

@Hailong-am Hailong-am merged commit 32888dd into opensearch-project:main Jul 31, 2024
11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 31, 2024
@github-actions
Initial implementation of context aware alert analysis (#215)
6826da3 
* support context aware alert analysis

Signed-off-by: Hailong Cui <[email protected]>

* Render GeneratePopover IncontextInsight component as a button to generate summary

Signed-off-by: Songkan Tang <[email protected]>

* Remove hardcoded assistant role from the parameter payload

Signed-off-by: Songkan Tang <[email protected]>

* Make GeneratePopoverBody as independent component

Signed-off-by: Songkan Tang <[email protected]>

* Update change log

Signed-off-by: Songkan Tang <[email protected]>

* Add independent GeneratePopoverBody ut and reorgnize constants

Signed-off-by: Songkan Tang <[email protected]>

* Simplify states of loading to get summary process

Signed-off-by: Songkan Tang <[email protected]>

* Make IncontextInsight not shareable and each component has its own IncontextInsight

Signed-off-by: Songkan Tang <[email protected]>

* Enable context aware alert only if feature flag is enabled

Signed-off-by: Songkan Tang <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Songkan Tang <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
(cherry picked from commit 32888dd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 31, 2024
Closed
@dblock dblock mentioned this pull request Aug 5, 2024
Closed
gaobinlong pushed a commit that referenced this pull request Sep 5, 2024
@songkant-aws @github-actions
Initial implementation of context aware alert analysis (#215) (#271)
4df9b30 
* support context aware alert analysis

Signed-off-by: Hailong Cui <[email protected]>

* Render GeneratePopover IncontextInsight component as a button to generate summary

Signed-off-by: Songkan Tang <[email protected]>

* Remove hardcoded assistant role from the parameter payload

Signed-off-by: Songkan Tang <[email protected]>

* Make GeneratePopoverBody as independent component

Signed-off-by: Songkan Tang <[email protected]>

* Update change log

Signed-off-by: Songkan Tang <[email protected]>

* Add independent GeneratePopoverBody ut and reorgnize constants

Signed-off-by: Songkan Tang <[email protected]>

* Simplify states of loading to get summary process

Signed-off-by: Songkan Tang <[email protected]>

* Make IncontextInsight not shareable and each component has its own IncontextInsight

Signed-off-by: Songkan Tang <[email protected]>

* Enable context aware alert only if feature flag is enabled

Signed-off-by: Songkan Tang <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Songkan Tang <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
(cherry picked from commit 32888dd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Signed-off-by: Songkan Tang <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit to ruanyl/dashboards-assistant that referenced this pull request Sep 6, 2024
@songkant-aws @github-actions @ruanyl
Initial implementation of context aware alert analysis (opensearch-pr…
57117da 
…oject#215) (opensearch-project#271)

* support context aware alert analysis

Signed-off-by: Hailong Cui <[email protected]>

* Render GeneratePopover IncontextInsight component as a button to generate summary

Signed-off-by: Songkan Tang <[email protected]>

* Remove hardcoded assistant role from the parameter payload

Signed-off-by: Songkan Tang <[email protected]>

* Make GeneratePopoverBody as independent component

Signed-off-by: Songkan Tang <[email protected]>

* Update change log

Signed-off-by: Songkan Tang <[email protected]>

* Add independent GeneratePopoverBody ut and reorgnize constants

Signed-off-by: Songkan Tang <[email protected]>

* Simplify states of loading to get summary process

Signed-off-by: Songkan Tang <[email protected]>

* Make IncontextInsight not shareable and each component has its own IncontextInsight

Signed-off-by: Songkan Tang <[email protected]>

* Enable context aware alert only if feature flag is enabled

Signed-off-by: Songkan Tang <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Songkan Tang <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
(cherry picked from commit 32888dd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Songkan Tang <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl added a commit that referenced this pull request Sep 6, 2024
@ruanyl @songkant-aws @github-actions
Initial implementation of context aware alert analysis (#215) (#271) (#…
2152d02 
…279)

* support context aware alert analysis



* Render GeneratePopover IncontextInsight component as a button to generate summary



* Remove hardcoded assistant role from the parameter payload



* Make GeneratePopoverBody as independent component



* Update change log



* Add independent GeneratePopoverBody ut and reorgnize constants



* Simplify states of loading to get summary process



* Make IncontextInsight not shareable and each component has its own IncontextInsight



* Enable context aware alert only if feature flag is enabled



---------




(cherry picked from commit 32888dd)

Signed-off-by: Songkan Tang <[email protected]>
Co-authored-by: Songkan Tang <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanglam wanglam wanglam approved these changes

@raintygao raintygao raintygao approved these changes

@Hailong-am Hailong-am Hailong-am approved these changes

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@gaobinlong gaobinlong Awaiting requested review from gaobinlong gaobinlong is a code owner

Assignees
No one assigned
Labels
backport 2.x Trigger the backport flow to 2.x v2.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@songkant-aws @wanglam @raintygao @Hailong-am