T2viz ux improvements #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanyl
requested review from
lezzago,
joshuali925,
anirudha,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
1. Only preselect index pattern that is enabled 2. Display an error toast when PPL query returns no result 3. Disable nature language input if no index pattern was selected Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
force-pushed
the
t2viz-ux-improvements
branch
from
58ca933
to
01bedc2
Compare
Hailong-am
reviewed
Sep 27, 2024
| @@ -342,16 +343,17 @@ export const Text2Viz = () => { | |||
| onChange={(e) => setInput(e.target.value)} | |||
| fullWidth | |||
| compressed | |||
| prepend={<EuiIcon type={chatIcon} />} | |||
| prepend={<EuiIcon type={config.branding.logo || chatIcon} />} | |||
There was a problem hiding this comment.
will config.branding.logo supports svg file?
There was a problem hiding this comment.
yes, url to svg is supported
| @@ -31,6 +31,7 @@ export const ActionContextMenu = (props: Props) => { | |||
| trigger: AI_ASSISTANT_QUERY_EDITOR_TRIGGER as any, | |||
| })), | |||
| closeMenu: () => setOpen(false), | |||
| title: '', | |||
There was a problem hiding this comment.
does this empty title is needed here?
There was a problem hiding this comment.
Yes, the default title is Options but we don't need a title, so set it to ''
Comment on lines
+66
to
+68
| if (res.rawResponse.total === 0) { | ||
| throw new Error(`There is no result with the generated query: '${value.ppl}'.`); | ||
| } |
There was a problem hiding this comment.
would there a place to show this error on page?
There was a problem hiding this comment.
Yes, in text2viz.tsx line 110
Hailong-am
approved these changes
Sep 27, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
* fix(t2viz): UI fix and improvements 1. Only preselect index pattern that is enabled 2. Display an error toast when PPL query returns no result 3. Disable nature language input if no index pattern was selected Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 3cdd0e2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ruanyl
pushed a commit
that referenced
this pull request
Sep 27, 2024
* fix(t2viz): UI fix and improvements 1. Only preselect index pattern that is enabled 2. Display an error toast when PPL query returns no result 3. Disable nature language input if no index pattern was selected Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 3cdd0e2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.