Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic uses of i18n #335

Merged
merged 1 commit into from
Sep 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- feat: register the AI actions to query controls in discover([#327](https://github.com/opensearch-project/dashboards-assistant/pull/327))
- fix: t2viz ux improvements([#330](https://github.com/opensearch-project/dashboards-assistant/pull/330))
- feat: report metrics for text to visualization([#312](https://github.com/opensearch-project/dashboards-assistant/pull/312))
- fix: Fix dynamic uses of i18n([#335](https://github.com/opensearch-project/dashboards-assistant/pull/335))

### 📈 Features/Enhancements

Expand Down
10 changes: 7 additions & 3 deletions public/components/incontext_insight/generate_popover_body.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,13 @@ export const GeneratePopoverBody: React.FC<{
<EuiText>
<EuiTitle size="xxs">
<h6>
{i18n.translate('assistantDashboards.incontextInsight.Summary', {
defaultMessage: showInsight ? 'Insight With RAG' : 'Summary',
})}
{showInsight
? i18n.translate('assistantDashboards.inContextInsight.withRAGSummary', {
defaultMessage: 'Insight With RAG',
})
: i18n.translate('assistantDashboards.inContextInsight.summary', {
defaultMessage: 'Summary',
})}
</h6>
</EuiTitle>
</EuiText>
Expand Down
Loading