[Backport 2.x] Hide "stop generation" and regenerate button based on feature flag #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
) * Add feature hide stop generation and regenerate button based on feature flag fixing issues Signed-off-by: hutiechuan <[email protected]> Signed-off-by: hutiechuan <[email protected]> fixing issues# Signed-off-by: hutiechuan <[email protected]> Add feature to hide "stop generation" and regenerate button based on feature flag * Signed-off-by: hutiechuan <[email protected]> fixing issues# * Signed-off-by: hutiechuan <[email protected]> fixing issues, getting rid of redundancy of props passings fixing lint-staged# * Signed-off-by: hutiechuan <[email protected]> add record in changelog to pass the changelog's CI# * feat: restore yarn.lock Signed-off-by: SuZhou-Joe <[email protected]> * feat: restore Signed-off-by: SuZhou-Joe <[email protected]> * feat: add unit test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: hutiechuan <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit f1e3de3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #414 +/- ##
==========================================
+ Coverage 85.00% 85.02% +0.01%
==========================================
Files 70 72 +2
Lines 2087 2103 +16
Branches 517 518 +1
==========================================
+ Hits 1774 1788 +14
- Misses 312 313 +1
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f1e3de3 from #394.