Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MDS on workflows and workflow_detail pages #274

Merged
merged 16 commits into from
Aug 12, 2024

Conversation

saimedhi
Copy link
Collaborator

Description

  • Added support for using MDS on workflows and workflow_detail pages.
  • Update all route paths to make it accept dataSourceId when it has truthy value.
  • MDS data picker has single datasource selectable view in workflows page.
  • MDS data picker has read-only view in workflow_detail page.
  • Tested the below senarios :
    • Turning on/off these two feature flags to ensure backward compatibility works fine.

      # Set the value of this setting to true to enable multiple data source feature.
      #data_source.enabled: false
      # Set the value of this setting to true to hide local cluster in data source feature.
      #data_source.hideLocalCluster: false
      
      
    • Switching between remote data source clusters to ensure workflow-related data and data source IDs are shown correctly (in url, breadcrumbs).

    • Proving that the workflow you created when remote data source A was connected can also be found in cluster A.

    • when you opening flow framework from the side nav, default remote data source should be selected

    • when you opening flow framework from a bookmarked url, the data source that's in the url should be selected

    • when you select a non default remote data source, it should still be selected if you refresh the page, instead of jumping back to the default one.

    • data source should be consistent through breadcrumbs

    • data source should be consistent through in-app side nav

Issues Resolved

closes #228

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

saimedhi and others added 15 commits July 31, 2024 01:22
Signed-off-by: saimedhi <[email protected]>
Signed-off-by: Sai Medhini Reddy Maryada <[email protected]>
Signed-off-by: saimedhi <[email protected]>
Signed-off-by: Sai Medhini Reddy Maryada <[email protected]>
Signed-off-by: saimedhi <[email protected]>
Signed-off-by: saimedhi <[email protected]>
Signed-off-by: saimedhi <[email protected]>
Signed-off-by: saimedhi <[email protected]>
Signed-off-by: saimedhi <[email protected]>
Signed-off-by: Sai Medhini Reddy Maryada <[email protected]>
Signed-off-by: Sai Medhini Reddy Maryada <[email protected]>
Signed-off-by: saimedhi <[email protected]>
Signed-off-by: saimedhi <[email protected]>
Signed-off-by: saimedhi <[email protected]>
Signed-off-by: saimedhi <[email protected]>
@saimedhi saimedhi marked this pull request as ready for review August 12, 2024 18:18
@jackiehanyang
Copy link
Collaborator

Reviewed the pr here - #253

@jackiehanyang
Copy link
Collaborator

synced with Sai offline, found a small functional issue. @saimedhi could you link the issue here? We can get this pr merged first and you can fix that issue later

@saimedhi
Copy link
Collaborator Author

synced with Sai offline, found a small functional issue. @saimedhi could you link the issue here? We can get this pr merged first and you can fix that issue later

Issue stated above is when clicking Flow Framework from side nav, dataSourceId is not retained in url. So, when page is refreshed as seen below, default datasource page is opened instead of current selected datasource. I will create an issue for this.

Apart from this issue, all other scenarios are properly tested and working. Thank you Jackie for reviewing testing.
screen-capture (4).webm

@jackiehanyang
Copy link
Collaborator

synced with Sai offline, found a small functional issue. @saimedhi could you link the issue here? We can get this pr merged first and you can fix that issue later

Issue stated above is when clicking Flow Framework from side nav, dataSourceId is not retained in url. So, when page is refreshed as seen below, default datasource page is opened instead of current selected datasource. I will create an issue for this.

Apart from this issue, all other scenarios are properly tested and working. Thank you Jackie for reviewing testing. screen-capture (4).webm

could you open an issue to track it?

@jackiehanyang jackiehanyang merged commit c8bc682 into opensearch-project:main Aug 12, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 12, 2024
* Added MDS support

Signed-off-by: saimedhi <[email protected]>

* Added MDS support, Fixed failing tests

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

---------

Signed-off-by: saimedhi <[email protected]>
Signed-off-by: Sai Medhini Reddy Maryada <[email protected]>
(cherry picked from commit c8bc682)
jackiehanyang pushed a commit that referenced this pull request Aug 12, 2024
* Added MDS support

Signed-off-by: saimedhi <[email protected]>

* Added MDS support, Fixed failing tests

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

* Fixing MDS Support

Signed-off-by: saimedhi <[email protected]>

---------

Signed-off-by: saimedhi <[email protected]>
Signed-off-by: Sai Medhini Reddy Maryada <[email protected]>
(cherry picked from commit c8bc682)

Co-authored-by: Sai Medhini Reddy Maryada <[email protected]>
@saimedhi saimedhi mentioned this pull request Aug 12, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support Multiple Data Source in Flow Framework Dashboards Plugin
2 participants