Skip to content

Commit

Permalink
[Look&Feel] Integrations Density and Consistency Improvements (#2071) (…
Browse files Browse the repository at this point in the history 
…#2083)

* Merged Main



* Reverted change



* Fixed error



* Updated snapshot testing



* Fix lint errors



---------


(cherry picked from commit 7cdcacb)

Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
@opensearch-trigger-bot @github-actions
opensearch-trigger-bot[bot] and github-actions[bot] authored Aug 22, 2024
1 parent d543458 commit 2d80408
Show file tree
Hide file tree
Showing 15 changed files with 175 additions and 123 deletions.
14 changes: 8 additions & 6 deletions ...omponents/integrations/components/__tests__/__snapshots__/added_integration.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -126,15 +126,17 @@ exports[`Added Integration View Test Renders added integration view using dummy
<div
className="euiFlexItem euiFlexItem--flexGrowZero"
>
<EuiTitle
<EuiText
data-test-subj="eventHomePageTitle"
size="l"
size="s"
>
<h1
className="euiTitle euiTitle--large"
<div
className="euiText euiText--small"
data-test-subj="eventHomePageTitle"
/>
</EuiTitle>
>
<h1 />
</div>
</EuiText>
</div>
</EuiFlexItem>
<EuiFlexItem
Expand Down
65 changes: 39 additions & 26 deletions ...ts/integrations/components/__tests__/__snapshots__/added_integration_flyout.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,14 @@ exports[`Add Integration Flyout Test Renders add integration flyout with dummy i
<div
class="euiFlyoutHeader euiFlyoutHeader--hasBorder"
>
<h2
class="euiTitle euiTitle--medium"
<div
class="euiText euiText--small"
data-test-subj="addIntegrationFlyoutTitle"
>
Add Integration
</h2>
<h2>
Add Integration
</h2>
</div>
</div>
<div
class="euiFlyoutBody"
Expand Down Expand Up @@ -406,12 +408,14 @@ exports[`Add Integration Flyout Test Renders add integration flyout with dummy i
<div
class="euiFlyoutHeader euiFlyoutHeader--hasBorder"
>
<h2
class="euiTitle euiTitle--medium"
<div
class="euiText euiText--small"
data-test-subj="addIntegrationFlyoutTitle"
>
Add Integration
</h2>
<h2>
Add Integration
</h2>
</div>
</div>
<div
class="euiFlyoutBody"
Expand Down Expand Up @@ -673,12 +677,14 @@ exports[`Add Integration Flyout Test Renders add integration flyout with dummy i
<div
class="euiFlyoutHeader euiFlyoutHeader--hasBorder"
>
<h2
class="euiTitle euiTitle--medium"
<div
class="euiText euiText--small"
data-test-subj="addIntegrationFlyoutTitle"
>
Add Integration
</h2>
<h2>
Add Integration
</h2>
</div>
</div>
<div
class="euiFlyoutBody"
Expand Down Expand Up @@ -940,12 +946,14 @@ exports[`Add Integration Flyout Test Renders add integration flyout with dummy i
<div
class="euiFlyoutHeader euiFlyoutHeader--hasBorder"
>
<h2
class="euiTitle euiTitle--medium"
<div
class="euiText euiText--small"
data-test-subj="addIntegrationFlyoutTitle"
>
Add Integration
</h2>
<h2>
Add Integration
</h2>
</div>
</div>
<div
class="euiFlyoutBody"
Expand Down Expand Up @@ -1195,12 +1203,14 @@ exports[`Add Integration Flyout Test Renders add integration flyout with dummy i
<div
class="euiFlyoutHeader euiFlyoutHeader--hasBorder"
>
<h2
class="euiTitle euiTitle--medium"
<div
class="euiText euiText--small"
data-test-subj="addIntegrationFlyoutTitle"
>
Add Integration
</h2>
<h2>
Add Integration
</h2>
</div>
</div>
<div
class="euiFlyoutBody"
Expand Down Expand Up @@ -1510,16 +1520,19 @@ exports[`Add Integration Flyout Test Renders add integration flyout with dummy i
<div
className="euiFlyoutHeader euiFlyoutHeader--hasBorder"
>
<EuiTitle
<EuiText
data-test-subj="addIntegrationFlyoutTitle"
size="s"
>
<h2
className="euiTitle euiTitle--medium"
<div
className="euiText euiText--small"
data-test-subj="addIntegrationFlyoutTitle"
>
Add Integration
</h2>
</EuiTitle>
<h2>
Add Integration
</h2>
</div>
</EuiText>
</div>
</EuiFlyoutHeader>
<EuiFlyoutBody>
Expand Down
96 changes: 52 additions & 44 deletions ...ponents/integrations/components/__tests__/__snapshots__/integration_details.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -147,52 +147,60 @@ exports[`Available Integration Table View Test Renders nginx integration table v
</h4>
</div>
</EuiText>
<EuiLink
external={true}
href="https://github.com/"
target="blank"
<EuiText
size="s"
>
<a
className="euiLink euiLink--primary"
href="https://github.com/"
rel="noreferrer"
target="blank"
<div
className="euiText euiText--small"
>
John Doe
<EuiIcon
aria-label="External link"
className="euiLink__externalIcon"
size="s"
type="popout"
<EuiLink
external={true}
href="https://github.com/"
target="blank"
>
<EuiIconBeaker
aria-hidden={true}
aria-label="External link"
className="euiIcon euiIcon--small euiIcon-isLoading euiLink__externalIcon"
focusable="false"
role="img"
style={null}
<a
className="euiLink euiLink--primary"
href="https://github.com/"
rel="noreferrer"
target="blank"
>
<svg
aria-hidden={true}
John Doe
<EuiIcon
aria-label="External link"
className="euiIcon euiIcon--small euiIcon-isLoading euiLink__externalIcon"
focusable="false"
height={16}
role="img"
style={null}
viewBox="0 0 16 16"
width={16}
xmlns="http://www.w3.org/2000/svg"
className="euiLink__externalIcon"
size="s"
type="popout"
>
<path
d="M5.277 10.088c.02.014.04.03.057.047.582.55 1.134.812 1.666.812.586 0 1.84-.293 3.713-.88L9 6.212V2H7v4.212l-1.723 3.876Zm-.438.987L3.539 14h8.922l-1.32-2.969C9.096 11.677 7.733 12 7 12c-.74 0-1.463-.315-2.161-.925ZM6 2H5V1h6v1h-1v4l3.375 7.594A1 1 0 0 1 12.461 15H3.54a1 1 0 0 1-.914-1.406L6 6V2Z"
/>
</svg>
</EuiIconBeaker>
</EuiIcon>
</a>
</EuiLink>
<EuiIconBeaker
aria-hidden={true}
aria-label="External link"
className="euiIcon euiIcon--small euiIcon-isLoading euiLink__externalIcon"
focusable="false"
role="img"
style={null}
>
<svg
aria-hidden={true}
aria-label="External link"
className="euiIcon euiIcon--small euiIcon-isLoading euiLink__externalIcon"
focusable="false"
height={16}
role="img"
style={null}
viewBox="0 0 16 16"
width={16}
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M5.277 10.088c.02.014.04.03.057.047.582.55 1.134.812 1.666.812.586 0 1.84-.293 3.713-.88L9 6.212V2H7v4.212l-1.723 3.876Zm-.438.987L3.539 14h8.922l-1.32-2.969C9.096 11.677 7.733 12 7 12c-.74 0-1.463-.315-2.161-.925ZM6 2H5V1h6v1h-1v4l3.375 7.594A1 1 0 0 1 12.461 15H3.54a1 1 0 0 1-.914-1.406L6 6V2Z"
/>
</svg>
</EuiIconBeaker>
</EuiIcon>
</a>
</EuiLink>
</div>
</EuiText>
</div>
</EuiFlexItem>
<EuiFlexItem>
Expand All @@ -209,10 +217,10 @@ exports[`Available Integration Table View Test Renders nginx integration table v
</div>
</EuiText>
<EuiText
size="m"
size="s"
>
<div
className="euiText euiText--medium"
className="euiText euiText--small"
>
Apache-2.0
</div>
Expand All @@ -235,10 +243,10 @@ exports[`Available Integration Table View Test Renders nginx integration table v
</div>
</EuiText>
<EuiText
size="m"
size="s"
>
<div
className="euiText euiText--medium"
className="euiText euiText--small"
>
Nginx HTTP server collector
</div>
Expand Down
19 changes: 11 additions & 8 deletions ...mponents/integrations/components/__tests__/__snapshots__/integration_header.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,19 @@ exports[`Integration Header Test Renders integration header as expected 1`] = `
<div
className="euiPageHeaderSection"
>
<EuiTitle
<EuiText
data-test-subj="integrations-header"
size="l"
size="s"
>
<h1
className="euiTitle euiTitle--large"
<div
className="euiText euiText--small"
data-test-subj="integrations-header"
>
Integrations
</h1>
</EuiTitle>
<h1>
Integrations
</h1>
</div>
</EuiText>
</div>
</EuiPageHeaderSection>
<EuiPageHeaderSection>
Expand Down Expand Up @@ -234,9 +236,10 @@ exports[`Integration Header Test Renders integration header as expected 1`] = `
</EuiSpacer>
<EuiTabs
display="condensed"
size="s"
>
<div
className="euiTabs euiTabs--condensed"
className="euiTabs euiTabs--condensed euiTabs--small"
role="tablist"
>
<EuiTab
Expand Down
16 changes: 10 additions & 6 deletions ...omponents/integrations/components/__tests__/__snapshots__/setup_integration.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,17 @@ exports[`Integration Setup Page Renders integration setup page as expected 1`] =
<div
className="euiForm"
>
<EuiTitle>
<h1
className="euiTitle euiTitle--medium"
<EuiText
size="s"
>
<div
className="euiText euiText--small"
>
Set Up Integration
</h1>
</EuiTitle>
<h1>
Set Up Integration
</h1>
</div>
</EuiText>
<EuiSpacer>
<div
className="euiSpacer euiSpacer--l"
Expand Down
18 changes: 12 additions & 6 deletions ...ts/integrations/components/__tests__/__snapshots__/setup_integration_inputs.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@

exports[`Integration Setup Inputs Renders the S3 connector form as expected 1`] = `
<EuiForm>
<EuiTitle>
<EuiText
size="s"
>
<h1>
Set Up Integration
</h1>
</EuiTitle>
</EuiText>
<EuiSpacer />
<EuiSpacer />
<EuiText>
Expand Down Expand Up @@ -253,11 +255,13 @@ exports[`Integration Setup Inputs Renders the S3 connector form as expected 1`]

exports[`Integration Setup Inputs Renders the S3 connector form without workflows 1`] = `
<EuiForm>
<EuiTitle>
<EuiText
size="s"
>
<h1>
Set Up Integration
</h1>
</EuiTitle>
</EuiText>
<EuiSpacer />
<EuiSpacer />
<EuiText>
Expand Down Expand Up @@ -1786,11 +1790,13 @@ exports[`Integration Setup Inputs Renders the details inputs 1`] = `

exports[`Integration Setup Inputs Renders the index form as expected 1`] = `
<EuiForm>
<EuiTitle>
<EuiText
size="s"
>
<h1>
Set Up Integration
</h1>
</EuiTitle>
</EuiText>
<EuiSpacer />
<EuiSpacer />
<EuiText>
Expand Down
8 changes: 7 additions & 1 deletion ...ic/components/integrations/components/__tests__/__snapshots__/upload_flyout.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,13 @@ exports[`Integration Upload Flyout Renders integration upload flyout as expected
size="s"
>
<EuiFlyoutHeader>
Upload Integrations
<EuiText
size="s"
>
<h2>
Upload Integrations
</h2>
</EuiText>
</EuiFlyoutHeader>
<EuiFlyoutBody>
<IntegrationUploadPicker
Expand Down
Loading

0 comments on commit 2d80408

Please sign in to comment.