added placeholder change for metrics picker (#1906)

* added placeholder change for metrics picker Signed-off-by: sumukhswamy <[email protected]> * updated release notes Signed-off-by: sumukhswamy <[email protected]> * updated tests Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]>
opensearch-project · Jun 12, 2024 · 3da9814 · 3da9814
1 parent 9864ef2
commit 3da9814
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/public/components/metrics/sidebar/__tests__/__snapshots__/sidebar.test.tsx.snap b/public/components/metrics/sidebar/__tests__/__snapshots__/sidebar.test.tsx.snap
@@ -184,7 +184,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
                       },
                     ]
                   }
-                  placeholder="Select a data source"
+                  placeholder="Select a metric source"
                   selectedOptions={Array []}
                   singleSelection={
                     Object {
@@ -216,7 +216,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
                       onFocus={[Function]}
                       onOpenListClick={[Function]}
                       onRemoveOption={[Function]}
-                      placeholder="Select a data source"
+                      placeholder="Select a metric source"
                       rootId={[Function]}
                       searchValue=""
                       selectedOptions={Array []}
@@ -259,7 +259,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
                               <p
                                 className="euiComboBoxPlaceholder"
                               >
-                                Select a data source
+                                Select a metric source
                               </p>
                               <AutosizeInput
                                 aria-controls=""

diff --git a/public/components/metrics/sidebar/data_source_picker.tsx b/public/components/metrics/sidebar/data_source_picker.tsx
@@ -17,8 +17,8 @@ export const DataSourcePicker = ({
   selectedDataSource,
   setSelectedDataSource,
 }: DataSourcePickerMenuProps) => {
-  const onChange = (selectedDataSource) => {
-    setSelectedDataSource(selectedDataSource);
+  const onChange = (selectedMetricSource) => {
+    setSelectedDataSource(selectedMetricSource);
   };
 
   return (
@@ -27,7 +27,7 @@ export const DataSourcePicker = ({
         <h5>Metrics source</h5>
       </EuiTitle>
       <EuiComboBox
-        placeholder="Select a data source"
+        placeholder="Select a metric source"
         singleSelection={{ asPlainText: true }}
         options={DATASOURCE_OPTIONS}
         selectedOptions={selectedDataSource || []}

diff --git a/release-notes/dashboards-observability.release-notes-2.15.0.0.md b/release-notes/dashboards-observability.release-notes-2.15.0.0.md
@@ -36,6 +36,7 @@ Compatible with OpenSearch and OpenSearch Dashboards version 2.15.0
 * [Bug fix] Add conditional rendering for data connection page's tabs ([#1756](https://github.com/opensearch-project/dashboards-observability/pull/1756))
 * removed update button from explorer ([#1755](https://github.com/opensearch-project/dashboards-observability/pull/1755))
 * (query assist) remove caching agent id ([#1734](https://github.com/opensearch-project/dashboards-observability/pull/1734))
+* added placeholder change for metrics picker ([#1906](https://github.com/opensearch-project/dashboards-observability/pull/1906))
 
 ### Maintenance
 * Remove mocha from dependencies ([#1890](https://github.com/opensearch-project/dashboards-observability/pull/1890))