Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct query schema for ELB mview generation #1196

Merged
merged 27 commits into from
Oct 27, 2023
Merged

Correct query schema for ELB mview generation #1196

merged 27 commits into from
Oct 27, 2023

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Oct 27, 2023

Description

Adds some corrections to the query to make more panels render correctly with default settings

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Swiddis
Switch heading types on setup page
283d663 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Merge remote-tracking branch 'upstream/main' into new-headers
d230445
@Swiddis
Add alb and nginx create table queries
55357df 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Merge remote-tracking branch 'upstream/main' into integ-queries
900c02d
@Swiddis
Switch from toast to callout for set up failures
725a4b4 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Fix label selection for truncated labels
75d4510 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Fix button color
f89bc70 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Fix tests
a83df4c 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Remove loading progress bar
3c30aba 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Remove unused imports
78fa19c 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Refactor labels to make distinctions more semantically useful
9f13cf0 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Merge remote-tracking branch 'upstream/main' into integ-loading
08dfb97
@Swiddis
Merge branch 'integ-loading' into integ-tags
f9a397d
@Swiddis
Merge branch 'integ-tags' into integ-queries
2c048e8
@Swiddis
Add running queries for ELB integration
1a01617 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Update tests
47cc88b 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Improve error handling for integration creation
e7ffde6 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Merge remote-tracking branch 'upstream/main' into integ-queries
385db93
@Swiddis
Resolve missed merge
23cd257 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Fix another missed merge marker
dba790b 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Remove buggy table from nginx
744e7b3 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Improve validation for integration setup
08867b5 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Make create flow actually use new field
c337aee 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Add onblur check to validation for s3 link
1f28a3c 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Update queries for parsing raw logs
0c266a6 
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Fix mview format
bf1b7d7 
Signed-off-by: Simeon Widdis <[email protected]>
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #1196 (bc581e1) into main (22b6fc6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1196   +/-   ##
=======================================
  Coverage   44.01%   44.01%           
=======================================
  Files         328      328           
  Lines       19644    19644           
  Branches     4730     4730           
=======================================
  Hits         8646     8646           
  Misses      10421    10421           
  Partials      577      577
Flag Coverage Δ
dashboards-observability 44.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@Swiddis Swiddis merged commit be978bf into opensearch-project:main Oct 27, 2023
11 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 27, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 27, 2023
@github-actions
Correct query schema for ELB mview generation (#1196)
d8f58a3 
(cherry picked from commit be978bf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 27, 2023
@github-actions
Correct query schema for ELB mview generation (#1196)
70ab6fc 
(cherry picked from commit be978bf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 27, 2023
Merged
Swiddis pushed a commit that referenced this pull request Oct 27, 2023
@opensearch-trigger-bot @github-actions
Correct query schema for ELB mview generation (#1196) (#1199)
0b7be95 
(cherry picked from commit be978bf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
YANG-DB pushed a commit that referenced this pull request Oct 30, 2023
@opensearch-trigger-bot @github-actions
Correct query schema for ELB mview generation (#1196) (#1198)
0884408 
(cherry picked from commit be978bf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric added a commit to mengweieric/dashboards-observability that referenced this pull request Nov 8, 2023
@mengweieric
Revert "Correct query schema for ELB mview generation (opensearch-pro…
02c56d6 
…ject#1196) (opensearch-project#1199)"

This reverts commit 0b7be95.
mengweieric added a commit to mengweieric/dashboards-observability that referenced this pull request Nov 8, 2023
@mengweieric
Revert "Correct query schema for ELB mview generation (opensearch-pro…
a59a262 
…ject#1196) (opensearch-project#1199)"

This reverts commit 0b7be95.

Signed-off-by: Eric <[email protected]>
mengweieric added a commit that referenced this pull request Nov 13, 2023
@mengweieric
Revert commits back to after 2.11 release (#1231)
c170e58 
* Revert "Update empty allowed roles to admin only (#1217) (#1220)"

This reverts commit 4288504.

Signed-off-by: Eric <[email protected]>

* Revert "Increment version to 2.11.1.0 (#1190)"

This reverts commit ccd5fb8.

Signed-off-by: Eric <[email protected]>

* Revert "Add S3 integration for Nginx and VPC (#1214) (#1216)"

This reverts commit e0a509c.

Signed-off-by: Eric <[email protected]>

* Revert "disabling inspect and default pattern/timestamp buttons when using async data sources (#1205) (#1212)"

This reverts commit ca5ad02.

Signed-off-by: Eric <[email protected]>

* Revert "Saved object datasource backward compatibility fixes (#1208) (#1210)"

This reverts commit 467a0b3.

Signed-off-by: Eric <[email protected]>

* Revert "Link integrations from datasources UI (#1203) (#1207)"

This reverts commit 8e9fe5e.

Signed-off-by: Eric <[email protected]>

* Revert "[Explorer] Fixes for cancel button and saved object loading (#1197) (#1201)"

This reverts commit f0e7a9d.

Signed-off-by: Eric <[email protected]>

* Revert "Correct query schema for ELB mview generation (#1196) (#1199)"

This reverts commit 0b7be95.

Signed-off-by: Eric <[email protected]>

* Revert "[Backport 2.11] Add integrations queries for Flint (#1195)"

This reverts commit 97f46ba.

Signed-off-by: Eric <[email protected]>

* Revert "remove husky pre-commit checks (#1192) (#1193)"

This reverts commit 25d52f3.

Signed-off-by: Eric <[email protected]>

* Revert "Bug fixes for observability count distribution and application analytics (#1187) (#1189)"

This reverts commit e2440d2.

Signed-off-by: Eric <[email protected]>

* Revert "Support cancellation of async queries (#1177) (#1186)"

This reverts commit 6b495f3.

Signed-off-by: Eric <[email protected]>

* Revert "[Explorer] Supports session for s3 direct query (#1178) (#1183)"

This reverts commit d50047f.

Signed-off-by: Eric <[email protected]>

* Revert "[Explorer] Modify text in empty prompt (#1172) (#1182)"

This reverts commit 95a60cc.

Signed-off-by: Eric <[email protected]>

* Revert "[Feature] Match discover look and feel (#1135) (#1179)"

This reverts commit b69801e.

Signed-off-by: Eric <[email protected]>

* Revert "config panel dark mode fix (#1169) (#1176)"

This reverts commit 34696b3.

Signed-off-by: Eric <[email protected]>

* Revert "Fix events home table and toast life time (#1170)"

This reverts commit a9b36fc.

Signed-off-by: Eric <[email protected]>

* Revert "Quiet react-dnd draggableId/droppableId warnings. (#1147) (#1166)"

This reverts commit a2f9a00.

Signed-off-by: Eric <[email protected]>

* Revert "Fix integration labeling to identify S3 integrations (#1157) (#1164)"

This reverts commit 9de9aea.

Signed-off-by: Eric <[email protected]>

* Revert "Remove loading progress for integration setup (#1156) (#1162)"

This reverts commit a08721b.

Signed-off-by: Eric <[email protected]>

* Revert "Switch from toast to callout for integration set up failures (#1155) (#1159)"

This reverts commit e6a474a.

Signed-off-by: Eric <[email protected]>

* Revert "Disable integration set up button if invalid (#1152) (#1161)"

This reverts commit 74aae17.

Signed-off-by: Eric <[email protected]>

* Revert "Update URL of create datasources, fix spacing (#1149) (#1154)"

This reverts commit 0b66d83.

Signed-off-by: Eric <[email protected]>

* Revert "Allow patch on allowedRoles (#1143) (#1145)"

This reverts commit 0acc0f3.

Signed-off-by: Eric <[email protected]>

* Revert "fix for explorer data grid not paginating (#1139) (#1141)"

This reverts commit c5ead50.

Signed-off-by: Eric <[email protected]>

---------

Signed-off-by: Eric <[email protected]>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
@opensearch-trigger-bot
Correct query schema for ELB mview generation (opensearch-project#1196)…
5930088 
… (opensearch-project#1198)

(cherry picked from commit be978bf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 0884408)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps48 ps48 ps48 approved these changes

@kavithacm kavithacm kavithacm approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@derek-ho derek-ho Awaiting requested review from derek-ho

@joshuali925 joshuali925 Awaiting requested review from joshuali925

@dai-chen dai-chen Awaiting requested review from dai-chen

@YANG-DB YANG-DB Awaiting requested review from YANG-DB

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric

@vamsi-amazon vamsi-amazon Awaiting requested review from vamsi-amazon

@penghuo penghuo Awaiting requested review from penghuo

@seankao-az seankao-az Awaiting requested review from seankao-az

@anirudha anirudha Awaiting requested review from anirudha

Assignees
No one assigned
Labels
backport 2.x backport 2.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Swiddis @ps48 @kavithacm