Fix integration child mapping validation bug #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
This was referenced Nov 9, 2023
|
Test failures seem to be entirely unrelated -- has something changed upstream? |
Signed-off-by: Simeon Widdis <[email protected]>
This reverts commit b2c533f. Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
force-pushed
the
fix-validation
branch
from
0ca532e
to
7fe6d24
Compare
YANG-DB
approved these changes
Nov 9, 2023
|
Closing as we're not backporting to 2.9 |
|
Reopening -- On discussion with team, it's important enough to backport for 2.9 |
Swiddis
added
the
integrations
ps48
approved these changes
Nov 22, 2023
|
@Swiddis you might need to fix tests here before merging |
|
It looks like all the failing tests aren't from this PR, I was asking around and got told that the tests on this branch are unstable. I searched for any failures related to these changes in the logs and didn't find anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #1148, integrations fails to validate some kinds of schemas, where child mappings don't align with the name of the mappings' properties. This is true for some SS4O mappings (like
httpandcommunication), but not all of them, which led to the issue being undetected.This PR fixes the bug and adds a corresponding test case. In the future, we should look at adding an integration test that tries to connect an integration to its own sample data, which would have caught this bug significantly faster.
Issues Resolved
Fixes validation bug for #1148
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.