Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relase Notes 2.11.1 #1262

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Relase Notes 2.11.1 #1262

merged 2 commits into from
Nov 27, 2023

Conversation

pjfitzgibbons
Copy link
Contributor

Description

Release Notes 2.11.1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Fitzgibbons <[email protected]>

### Features

- [Feature] Match discover look and feel by @opensearch-trigger-bot in ([#1179](https://github.com/opensearch-project/dashboards-observability/pull/1179)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: would be nice to be able to link the original author instead of the backport bot

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (135a3d1) 44.22% compared to head (e0040b9) 56.81%.

Additional details and impacted files
@@             Coverage Diff             @@
##             2.11    #1262       +/-   ##
===========================================
+ Coverage   44.22%   56.81%   +12.58%     
===========================================
  Files         327      325        -2     
  Lines       19477    11739     -7738     
  Branches     4643     2699     -1944     
===========================================
- Hits         8614     6669     -1945     
+ Misses      10818     5025     -5793     
  Partials       45       45               
Flag Coverage Δ
dashboards-observability 56.81% <ø> (+12.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


### Features

- [Feature] Match discover look and feel by @opensearch-trigger-bot in ([#1179](https://github.com/opensearch-project/dashboards-observability/pull/1179)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature? In a PATCH release?

https://semver.org/#spec-item-6

Patch version Z (x.y.Z | x > 0) MUST be incremented if only backward compatible bug fixes are introduced. A bug fix is defined as an internal change that fixes incorrect behavior.

Have not all non-bugfix backports been revert?

Copy link
Member

@dblock dblock Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they have an the release notes were fixed in #1273. This was an oversight. There's also some confusion on why this is under a "refactor" section, but either way it got reverted from the patch release. Sorry about that.

Copy link
Collaborator

@anirudha anirudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be a feature / can you double check please

#1179 was part of the revert commit. 

Signed-off-by: Peter Fitzgibbons <[email protected]>
@pjfitzgibbons
Copy link
Contributor Author

should not be a feature / can you double check please

Yep. WAs part of the revert commit. I missed it.
c170e58

No features.
@anirudha please review.

@pjfitzgibbons pjfitzgibbons merged commit 8b598a8 into 2.11 Nov 27, 2023
11 checks passed
@dblock
Copy link
Member

dblock commented Nov 28, 2023

@smortex Thanks. These notes are looking incorrect.

RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
…roject#1266)

Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Peter Nied <[email protected]>
(cherry picked from commit 4cb6252090696b81fcd9410b74a830479fabbebb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants