Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add i18n support for acceleration panels #1564

Closed

Conversation

RyanL1997
Copy link
Collaborator

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RyanL1997 RyanL1997 added backport 2.x enhancement New feature or request labels Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 48.14815% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 57.59%. Comparing base (2d16727) to head (baa98d7).

Files Patch % Lines
...nage/accelerations/acceleration_action_overlay.tsx 0.00% 8 Missing ⚠️
...ts/manage/accelerations/acceleration_operation.tsx 42.85% 4 Missing ⚠️
...tions_flyout/create/create_acceleration_button.tsx 0.00% 1 Missing ⚠️
...ations/flyout_modules/acceleration_details_tab.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1564      +/-   ##
==========================================
- Coverage   57.60%   57.59%   -0.01%     
==========================================
  Files         367      367              
  Lines       13921    13929       +8     
  Branches     3651     3652       +1     
==========================================
+ Hits         8019     8023       +4     
- Misses       5839     5843       +4     
  Partials       63       63              
Flag Coverage Δ
dashboards-observability 57.59% <48.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

opensearch_dashboards.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@RyanL1997 RyanL1997 changed the title [Enhancement] Add i18n support for Flint's datasource panels [Enhancement] Add i18n support for acceleration panels Mar 19, 2024
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
…oject#1564) (opensearch-project#1629)

* changing return to dashboards with functioning logout button on error page

Signed-off-by: [email protected] <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
Co-authored-by: Peter Nied <[email protected]>
(cherry picked from commit 27c37d40221bdc07f0167eca6348806d6b876dd6)

Co-authored-by: leanneeliatra <[email protected]>
@RyanL1997 RyanL1997 closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant