Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [BUG-Fixed] #1466 - create observability dashboard after invalid name #1928

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from
Open

[Backport 2.x] [BUG-Fixed] #1466 - create observability dashboard after invalid name #1928

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a8682c
[BUG-Fixed] #1466 - create observability dashboard after creating wit…
github-actions[bot] Jun 28, 2024
10c5d51
Merge branch '2.x' into backport/backport-1730-to-2.x
ps48 Jul 23, 2024
78f2358
Merge branch '2.x' into backport/backport-1730-to-2.x
RyanL1997 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions public/components/custom_panels/custom_panel_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ export const CustomPanelTable = ({

const onCreate = async (newCustomPanelName: string) => {
if (!isNameValid(newCustomPanelName)) {
setToast('Invalid Dashboard name', 'danger');
setToast('Invalid Dashboard Name', 'danger');
history.goBack();
} else {
const newPanel = newPanelTemplate(newCustomPanelName);
dispatch(createPanel(newPanel));
Expand All @@ -130,7 +131,7 @@ export const CustomPanelTable = ({

const onRename = async (newCustomPanelName: string) => {
if (!isNameValid(newCustomPanelName)) {
setToast('Invalid Dashboard name', 'danger');
setToast('Invalid Dashboard Name', 'danger');
} else {
dispatch(renameCustomPanel(newCustomPanelName, selectedCustomPanels[0].id));
}
Expand All @@ -139,7 +140,7 @@ export const CustomPanelTable = ({

const onClone = async (newName: string) => {
if (!isNameValid(newName)) {
setToast('Invalid Operational Panel name', 'danger');
setToast('Invalid Operational Panel Name', 'danger');
} else {
let sourcePanel = selectedCustomPanels[0];
try {
Expand Down
Loading