Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Look&Feel] Traces Density and Consistency Improvements #2072

Merged
merged 4 commits into from
Aug 21, 2024
Merged

[Look&Feel] Traces Density and Consistency Improvements #2072

merged 4 commits into from
Aug 21, 2024

Conversation

danieldong51
Copy link
Contributor

@danieldong51 danieldong51 commented Aug 19, 2024 •
edited
Loading

Description

This PR applies the Look & Feel density and consistency changes to Traces and Metrics:

  1. Use small context menus
  2. Use small tabs
  3. Standardize paragraph size (15.75px next theme / 14px V7 theme)
  4. Use semantic headers (H1s on main pages, H2s on modals/flyouts)
  5. Modal/Flyout Typography
  6. Buttons for actions, only using primary buttons for primary calls to action
  7. Use small padding on popovers

Screenshots

Metrics: Popover Padding

Scope Before After
Metrics Popover Before Popover Post

Small context Menu

Scope Before After
Save Trace Save Popover Before Trace Save Popover Post
Filters Trace Analytics Filters Before Trace Analytics Post
Actions Trace Actions Popover Before Trace Actions Popover Post

Buttons

Scope Before After
Empty Trace Empty Button Before Trace Empty Button Post

Paragraph size

Scope Before After
Empty Trace Empty Message Before Trace Empty Message Post
Map Trace Map Node Before Trace Map Node Post

Semantic Headers

Scope Before After
Trace ID Trace View ID Before Trace View ID Post
Service Traces Service Page Before Traces Service Page Post

Flyouts

Scope Before After
Header Trace Header Before Trace Header Post
Span Header Trace Span Header Before Trace Span Header Post

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@danieldong51 danieldong51 marked this pull request as ready for review August 19, 2024 23:59
derek-ho
derek-ho approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

virajsanghvi
virajsanghvi approved these changes Aug 20, 2024
View reviewed changes
Copy link

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, although probably need to validate failing checks

@TackAdam TackAdam merged commit 386522c into opensearch-project:main Aug 21, 2024
15 of 22 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 21, 2024
@github-actions
[Look&Feel] Traces Density and Consistency Improvements (#2072)
b956c52 
* Updated Traces Look & Feel

Signed-off-by: Dan Dong <[email protected]>

* Look&Feel for Metrics

Signed-off-by: Dan Dong <[email protected]>

* Fixed error

Signed-off-by: Dan Dong <[email protected]>

* Fixed snapshot testing

Signed-off-by: Dan Dong <[email protected]>

---------

Signed-off-by: Dan Dong <[email protected]>
(cherry picked from commit 386522c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 21, 2024
Merged
TackAdam pushed a commit that referenced this pull request Aug 22, 2024
@opensearch-trigger-bot @github-actions
[Look&Feel] Traces Density and Consistency Improvements (#2072) (#2084)
e559f3b 
* Updated Traces Look & Feel



* Look&Feel for Metrics



* Fixed error



* Fixed snapshot testing



---------


(cherry picked from commit 386522c)

Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ps48 ps48 mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajsanghvi virajsanghvi virajsanghvi approved these changes

@derek-ho derek-ho derek-ho approved these changes

@Swiddis Swiddis Swiddis approved these changes

@TackAdam TackAdam TackAdam approved these changes

@ps48 ps48 Awaiting requested review from ps48

@kavithacm kavithacm Awaiting requested review from kavithacm

@joshuali925 joshuali925 Awaiting requested review from joshuali925

@dai-chen dai-chen Awaiting requested review from dai-chen

@YANG-DB YANG-DB Awaiting requested review from YANG-DB

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric

@vamsi-amazon vamsi-amazon Awaiting requested review from vamsi-amazon

@penghuo penghuo Awaiting requested review from penghuo

@seankao-az seankao-az Awaiting requested review from seankao-az

@anirudha anirudha Awaiting requested review from anirudha

@paulstn paulstn Awaiting requested review from paulstn

@sumukhswamy sumukhswamy Awaiting requested review from sumukhswamy

Assignees
No one assigned
Labels
backport 2.x maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danieldong51 @virajsanghvi @derek-ho @Swiddis @TackAdam