Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]fixed traces bug for missing MDS id #2100

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

sumukhswamy
Copy link
Collaborator

Description

added parameter in flyout for mds

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ps48 ps48 added the enhancement New feature or request label Aug 28, 2024
Signed-off-by: sumukhswamy <[email protected]>
@ps48
Copy link
Member

ps48 commented Sep 4, 2024

@sumukhswamy Looks like app analytics has some import issues for header controls. Can you please take a look

Signed-off-by: sumukhswamy <[email protected]>
@ps48 ps48 merged commit 744a039 into opensearch-project:main Sep 4, 2024
8 of 18 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
* fixed traces bug

Signed-off-by: sumukhswamy <[email protected]>

* addressed conflicts

Signed-off-by: sumukhswamy <[email protected]>

---------

Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: Sumukh Swamy <[email protected]>
(cherry picked from commit 744a039)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
* fixed traces bug

Signed-off-by: sumukhswamy <[email protected]>

* addressed conflicts

Signed-off-by: sumukhswamy <[email protected]>

---------

Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: Sumukh Swamy <[email protected]>
(cherry picked from commit 744a039)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sumukhswamy pushed a commit that referenced this pull request Sep 4, 2024
* fixed traces bug



* addressed conflicts



---------



(cherry picked from commit 744a039)

Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: Sumukh Swamy <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sumukhswamy pushed a commit that referenced this pull request Sep 4, 2024
* fixed traces bug



* addressed conflicts



---------



(cherry picked from commit 744a039)

Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: Sumukh Swamy <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.15 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.15
# Create a new branch
git switch --create backport/backport-2100-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 744a0390565c088d59e7ae63a8ae9e3ac3f37cb1
# Push it to GitHub
git push --set-upstream origin backport/backport-2100-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.15

Then, create a pull request where the base branch is 2.15 and the compare/head branch is backport/backport-2100-to-2.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants