[BUG]fix add sample notebooks #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuali925
reviewed
Sep 3, 2024
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
sumukhswamy
force-pushed
the
notebooks-sample-fix
branch
from
fba0d8a
to
a021893
Compare
Signed-off-by: sumukhswamy <[email protected]>
ps48
approved these changes
Sep 4, 2024
Signed-off-by: sumukhswamy <[email protected]>
joshuali925
approved these changes
Sep 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* fix add sample notebooks Signed-off-by: sumukhswamy <[email protected]> * changes for label Signed-off-by: sumukhswamy <[email protected]> * updated apis when MDS is disabled Signed-off-by: sumukhswamy <[email protected]> * asddressed comments Signed-off-by: sumukhswamy <[email protected]> * addressed comments Signed-off-by: sumukhswamy <[email protected]> * updated the comments Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit 0550228) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* fix add sample notebooks Signed-off-by: sumukhswamy <[email protected]> * changes for label Signed-off-by: sumukhswamy <[email protected]> * updated apis when MDS is disabled Signed-off-by: sumukhswamy <[email protected]> * asddressed comments Signed-off-by: sumukhswamy <[email protected]> * addressed comments Signed-off-by: sumukhswamy <[email protected]> * updated the comments Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit 0550228) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Sep 5, 2024
* fix add sample notebooks * changes for label * updated apis when MDS is disabled * asddressed comments * addressed comments * updated the comments --------- (cherry picked from commit 0550228) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Sep 5, 2024
* fix add sample notebooks * changes for label * updated apis when MDS is disabled * asddressed comments * addressed comments * updated the comments --------- (cherry picked from commit 0550228) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add sample notebooks was failing in NEO as the sample data did not have a cluster to point to, so have updated the Apis to reflect the MDS id for samples
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.