[Feature] UI update to notebooks and applications #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <[email protected]>
joshuali925
reviewed
Sep 4, 2024
|
|
||
| // Close the delete modal | ||
| fireEvent.click(getByText('Cancel')); | ||
|
|
||
| // Ensure the delete modal is closed | ||
| expect(queryByText('Delete 1 notebook')).toBeNull(); | ||
| expect(getAllByText('Delete 1 notebook')).toHaveLength(1); |
There was a problem hiding this comment.
are the comments still accurate? it says ensure modal is closed, but still expects model text to be found?
There was a problem hiding this comment.
The new functionality adds the delete button to the left of the search bar containing the text. Once the modal is closed the expected behavior is that it is still selected so we still have the (new) button. If the modal is open the text should appear twice.
paulstn
approved these changes
Sep 4, 2024
sumukhswamy
approved these changes
Sep 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 1c6ff11) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 1c6ff11) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Sep 4, 2024
…) (#2114) (cherry picked from commit 1c6ff11) Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]>
ps48
pushed a commit
that referenced
this pull request
Sep 4, 2024
…) (#2115) (cherry picked from commit 1c6ff11) Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]>
ps48
added a commit
that referenced
this pull request
Sep 4, 2024
…2117) * fix badge size for counters, change notebook delete, update test (#2110) (#2114) (cherry picked from commit 1c6ff11) Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]> * Trace Analytics support for custom sources (#2112) * improve traces table Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 2e052f2) * improve queries Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit d832ea1) * add support for custom trace indices Signed-off-by: Shenoy Pratik <[email protected]> * update mode picker Signed-off-by: Shenoy Pratik <[email protected]> * added services view for custom trace source Signed-off-by: Shenoy Pratik <[email protected]> * updated snapshots Signed-off-by: Shenoy Pratik <[email protected]> * update DSL filter tests Signed-off-by: Shenoy Pratik <[email protected]> * update app analytics snapshots Signed-off-by: Shenoy Pratik <[email protected]> * remove console.log Signed-off-by: Shenoy Pratik <[email protected]> * update service map inputs, remove commented code Signed-off-by: Shenoy Pratik <[email protected]> * remove console.log, update copy and tests Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Joshua Li <[email protected]> (cherry picked from commit ec67ad1) * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots from upstream changes Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notebooks delete before:
After:
Screen.Recording.2024-08-30.at.10.21.21.AM.mov
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.