[query assist] update api handler to accommodate new ml-commons config response #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g response Signed-off-by: Joshua Li <[email protected]>
lezzago
reviewed
Sep 3, 2024
| @@ -34,12 +34,19 @@ export const getAgentIdByConfig = async ( | |||
| const response = (await opensearchClient.transport.request({ | |||
| method: 'GET', | |||
| path: `${ML_COMMONS_API_PREFIX}/config/${configName}`, | |||
| })) as ApiResponse<{ type: string; configuration: { agent_id?: string } }>; | |||
| })) as ApiResponse<{ | |||
| type: string; | |||
There was a problem hiding this comment.
type can also be config_type. We should maybe check for that as well even though we dont use the value from it
Signed-off-by: Joshua Li <[email protected]>
lezzago
approved these changes
Sep 3, 2024
TackAdam
approved these changes
Sep 3, 2024
ps48
approved these changes
Sep 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…g response (#2111) * [query assist] update api handler to accommodate new ml-commons config response Signed-off-by: Joshua Li <[email protected]> * update `type` field in ml-commons response Signed-off-by: Joshua Li <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 6d128ea) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…g response (#2111) * [query assist] update api handler to accommodate new ml-commons config response Signed-off-by: Joshua Li <[email protected]> * update `type` field in ml-commons response Signed-off-by: Joshua Li <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 6d128ea) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Sep 4, 2024
…g response (#2111) (#2120) * [query assist] update api handler to accommodate new ml-commons config response * update `type` field in ml-commons response --------- (cherry picked from commit 6d128ea) Signed-off-by: Joshua Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Sep 4, 2024
…g response (#2111) (#2121) * [query assist] update api handler to accommodate new ml-commons config response * update `type` field in ml-commons response --------- (cherry picked from commit 6d128ea) Signed-off-by: Joshua Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update api handler to accommodate new ml-commons config response
Issues Resolved
addresses breaking change from opensearch-project/ml-commons#2710
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.