Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query assist] update ml-commons response schema #2124

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Sep 4, 2024

Description

update logic to process ml-commons response schema. error.body was a string before, now it is a JSON object. converting to string for backward compatibility

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 changed the title [query assist] update ml-commons response schema processing [query assist] update ml-commons response schema Sep 4, 2024
@TackAdam TackAdam added the enhancement New feature or request label Sep 5, 2024
@ps48 ps48 merged commit acff04b into opensearch-project:main Sep 5, 2024
11 of 20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
* [query assist] update ml-commons response schema processing

Signed-off-by: Joshua Li <[email protected]>

* disable query assist routes when data source is enabled

Signed-off-by: Joshua Li <[email protected]>

---------

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit acff04b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
* [query assist] update ml-commons response schema processing

Signed-off-by: Joshua Li <[email protected]>

* disable query assist routes when data source is enabled

Signed-off-by: Joshua Li <[email protected]>

---------

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit acff04b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925 pushed a commit that referenced this pull request Sep 5, 2024
(cherry picked from commit acff04b)

Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925 pushed a commit that referenced this pull request Sep 5, 2024
(cherry picked from commit acff04b)

Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants