Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]feat: update category to flatten menus in analytics(all) use case #2182

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Sep 26, 2024

Description

Based on opensearch-project/OpenSearch-Dashboards#8332, observability needs to make some adjustment to flatten the menus in analytics(all) use case.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe changed the title [navigation] feat: change categories of some applications with observability [navigation]feat: change categories of some applications with observability Sep 26, 2024
@SuZhou-Joe SuZhou-Joe changed the title [navigation]feat: change categories of some applications with observability [navigation]feat: update category to flatten menus in analytics(all) use case Sep 26, 2024
@TackAdam
Copy link
Collaborator

Screenshot 2024-09-26 at 8 37 56 AM

Should the "see all..." still be present with this change? or is that showing up because we still register "applications" when the multi data source is disabled?(might need to be added to all as well)

@SuZhou-Joe
Copy link
Member Author

SuZhou-Joe commented Sep 26, 2024

The see all button will be removed by PR opensearch-project/OpenSearch-Dashboards#8332 and we had to have a intermedia state that we have all the features in all use case and has a additional see all link until the PR get merged.

@SuZhou-Joe
Copy link
Member Author

I see, for applications, if that's the case then yes we need to add it to all use case. Let me adjust it a little bit.

Copy link
Collaborator

@TackAdam TackAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@TackAdam TackAdam added enhancement New feature or request backport 2.x labels Sep 26, 2024
@ps48 ps48 merged commit 6f74002 into opensearch-project:main Sep 27, 2024
13 of 22 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 27, 2024
…use case (#2182)

* feat: update category

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add applications to all use case

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
(cherry picked from commit 6f74002)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho pushed a commit that referenced this pull request Sep 30, 2024
…use case (#2182) (#2184)

* feat: update category



* feat: add applications to all use case



---------


(cherry picked from commit 6f74002)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants