[Backport 2.x] Traces/Services - Query optimization / UI setting / Bugfix #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* improve service node query and related services query Signed-off-by: Adam Tackett <[email protected]> * update url redirection for services for the table and expanded view actions Signed-off-by: Adam Tackett <[email protected]> * remove extra toast messages from handleServiceMapRequest Signed-off-by: Adam Tackett <[email protected]> * add observability setting for enabling custom source as the default mode Signed-off-by: Adam Tackett <[email protected]> * fix bug returning errors on spans that have a status.code === 1 Signed-off-by: Adam Tackett <[email protected]> * fix bug causing infinite refrshed if mds disabled and services trace link clicked Signed-off-by: Adam Tackett <[email protected]> * add the mode param to url for services - trace redirection Signed-off-by: Adam Tackett <[email protected]> * fix flaky cypress test for services Signed-off-by: Adam Tackett <[email protected]> * address comments Signed-off-by: Adam Tackett <[email protected]> * remove test, add comment, remove related service param Signed-off-by: Adam Tackett <[email protected]> * place related services back Signed-off-by: Adam Tackett <[email protected]> * add type for serviceMapParams, im prove readability, remove related servics Signed-off-by: Adam Tackett <[email protected]> * update service map test for the new type Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 8016a73) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
anirudha and
TackAdam
as code owners
TackAdam
approved these changes
Jan 17, 2025
joshuali925
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8016a73 from #2310.