Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.5] Merge pull request #588 from mengweieric/feature/prerelease-code-cleanup #599

Merged

Conversation

mengweieric
Copy link
Collaborator

(cherry picked from commit a85b716)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #599 (896c390) into 2.5 (8f52064) will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.5     #599      +/-   ##
==========================================
+ Coverage   38.04%   38.22%   +0.18%     
==========================================
  Files         260      255       -5     
  Lines       15833    15805      -28     
  Branches     4312     4299      -13     
==========================================
+ Hits         6023     6042      +19     
+ Misses       9769     9714      -55     
- Partials       41       49       +8     
Flag Coverage Δ
dashboards-observability 38.22% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

@mengweieric mengweieric merged commit 118b59b into opensearch-project:2.5 Jul 5, 2023
6 of 8 checks passed
@mengweieric mengweieric deleted the backport/backport-588-to-2.5 branch July 5, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants