Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve heatmap issue and update snapshots #601

Merged

Conversation

mengweieric
Copy link
Collaborator

Description

Resolve heatmap issue and update snapshots.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #601 (8e76ced) into 2.4 (cb8ccc9) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              2.4     #601      +/-   ##
==========================================
- Coverage   37.24%   37.21%   -0.04%     
==========================================
  Files         254      249       -5     
  Lines       15352    15337      -15     
  Branches     4029     4063      +34     
==========================================
- Hits         5718     5707      -11     
+ Misses       9603     9591      -12     
- Partials       31       39       +8     
Flag Coverage Δ
dashboards-observability 37.21% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...visualizations/visualization_specs/default_spec.ts 100.00% <ø> (ø)
...c/components/visualizations/charts/bar/bar_type.ts 100.00% <ø> (ø)
...onents/visualizations/charts/bubble/bubble_type.ts 100.00% <ø> (ø)
...isualizations/charts/data_table/data_table_type.ts 100.00% <ø> (ø)
...isualizations/charts/financial/gauge/gauge_type.ts 100.00% <ø> (ø)
...omponents/visualizations/charts/lines/line_type.ts 77.77% <ø> (ø)
.../visualizations/charts/logs_view/logs_view_type.ts 100.00% <ø> (ø)
...ponents/visualizations/charts/maps/heatmap_type.ts 100.00% <ø> (ø)
...ents/visualizations/charts/metrics/metrics_type.ts 100.00% <ø> (ø)
...c/components/visualizations/charts/pie/pie_type.ts 100.00% <ø> (ø)
... and 2 more

... and 4 files with indirect coverage changes

@mengweieric mengweieric merged commit fed75fb into opensearch-project:2.4 Jul 5, 2023
7 of 8 checks passed
@mengweieric mengweieric deleted the backport/backport-588-to-2.4 branch July 5, 2023 19:51
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.3 2.3
# Navigate to the new working tree
cd .worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-601-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fed75fb72f1ff154d5a5026052e481e85105fabb
# Push it to GitHub
git push --set-upstream origin backport/backport-601-to-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.3

Then, create a pull request where the base branch is 2.3 and the compare/head branch is backport/backport-601-to-2.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.2 2.2
# Navigate to the new working tree
cd .worktrees/backport-2.2
# Create a new branch
git switch --create backport/backport-601-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fed75fb72f1ff154d5a5026052e481e85105fabb
# Push it to GitHub
git push --set-upstream origin backport/backport-601-to-2.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.2

Then, create a pull request where the base branch is 2.2 and the compare/head branch is backport/backport-601-to-2.2.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.1 2.1
# Navigate to the new working tree
cd .worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-601-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fed75fb72f1ff154d5a5026052e481e85105fabb
# Push it to GitHub
git push --set-upstream origin backport/backport-601-to-2.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.1

Then, create a pull request where the base branch is 2.1 and the compare/head branch is backport/backport-601-to-2.1.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-601-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fed75fb72f1ff154d5a5026052e481e85105fabb
# Push it to GitHub
git push --set-upstream origin backport/backport-601-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-601-to-2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants