Cypress v12.8.1 - Remade all Cypress test for visualizations charts #679
Conversation
Signed-off-by: TackAdam <[email protected]>
TackAdam
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Codecov Report
@@ Coverage Diff @@
## main #679 +/- ##
==========================================
+ Coverage 43.42% 43.59% +0.17%
==========================================
Files 300 312 +12
Lines 18113 18581 +468
Branches 4447 4479 +32
==========================================
+ Hits 7866 8101 +235
- Misses 9712 10438 +726
+ Partials 535 42 -493
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
.cypress/integration/VisualizationCharts/10_horizontalBar_chart.spec.js
Outdated
Show resolved
Hide resolved
Signed-off-by: TackAdam <[email protected]>
| @@ -0,0 +1,210 @@ | |||
| /* | |||
There was a problem hiding this comment.
What is the reason to rename/renumber the files?
There was a problem hiding this comment.
Was trying to follow the formatting of going in order of the visualizations appearing. After removing the visualizations we don't have I just numbered them in the order they appear in explorer.
| 'STDDEV_SAMP', | ||
| 'STDDEV_POP', | ||
| ]; | ||
|
|
||
| export const querySearch = (query, rangeSelected) => { |
There was a problem hiding this comment.
As a code hygiene concern, we try to keep constants and functions (helper functions) in separate files.
This separation helps b/c it's easier to scan the files of "like kind" code. The two files might change at different paces (yes, this is testing, both are likely slow-moving files)... the churn could be less with the separation.
Even though a lot of the code in utils/event_analytics/constants.js was pre-existing, this would be a convenient time to re-organize the file (split).
There was a problem hiding this comment.
Good catch, separated all helper functions and removed from the constants file.
Signed-off-by: TackAdam <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-679-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5c96cc624ddbac6c3427187e45787fde8906a0d3
# Push it to GitHub
git push --set-upstream origin backport/backport-679-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
Cypress v12.8.1 - Remade all Cypress test for visualizations charts (cherry picked from commit 5c96cc6) Signed-off-by: TackAdam <[email protected]>
Cypress v12.8.1 - Remade all Cypress test for visualizations charts (cherry picked from commit 5c96cc6) Signed-off-by: TackAdam <[email protected]>
…earch-project#729) Cypress v12.8.1 - Remade all Cypress test for visualizations charts (cherry picked from commit 5c96cc6) Signed-off-by: TackAdam <[email protected]> (cherry picked from commit ebf2c6a)
Description
[Describe what this change achieves]
Removed Cypress testing for visuals we don't have.
Created Cypress testing for all existing visualization options in explorer.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.