[Bug]fix for missing id in old nav #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sumukhswamy <[email protected]>
sumukhswamy
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
Yury-Fridlyand,
anirudha and
paulstn
as code owners
Signed-off-by: sumukhswamy <[email protected]>
joshuali925
reviewed
Sep 3, 2024
| @@ -295,6 +296,7 @@ export class Main extends React.Component<MainProps, MainState> { | |||
| selectedMDSDataConnectionId: this.props.dataSourceMDSId, | |||
| mdsClusterName: '', | |||
| flintDataConnections: false, | |||
| newNavEnabled: coreRefs?.chrome?.navGroup.getNavGroupEnabled(), | |||
There was a problem hiding this comment.
this doesn't seem to change, is it necessary to store as a state?
There was a problem hiding this comment.
the state can change if its toggeled in the settings
Signed-off-by: sumukhswamy <[email protected]>
ps48
approved these changes
Sep 4, 2024
TackAdam
approved these changes
Sep 4, 2024
Signed-off-by: sumukhswamy <[email protected]>
derek-ho
approved these changes
Sep 4, 2024
Signed-off-by: sumukhswamy <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* fix for missing id in old nav Signed-off-by: sumukhswamy <[email protected]> * updated the branch Signed-off-by: sumukhswamy <[email protected]> * addressed comments Signed-off-by: sumukhswamy <[email protected]> * addressed comments Signed-off-by: sumukhswamy <[email protected]> * addressed comments Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit db88704) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* fix for missing id in old nav Signed-off-by: sumukhswamy <[email protected]> * updated the branch Signed-off-by: sumukhswamy <[email protected]> * addressed comments Signed-off-by: sumukhswamy <[email protected]> * addressed comments Signed-off-by: sumukhswamy <[email protected]> * addressed comments Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit db88704) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Sep 5, 2024
* fix for missing id in old nav * updated the branch * addressed comments * addressed comments * addressed comments --------- (cherry picked from commit db88704) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Sep 5, 2024
* fix for missing id in old nav * updated the branch * addressed comments * addressed comments * addressed comments --------- (cherry picked from commit db88704) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Side tree was not loading in the case of ols nav as the MDS id was not being passed,
after Fix
Issues Resolved
There was no ID added from this pr which was causing the page to not refresh
#349
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.