Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.11 Bug fix for checking Date Field presence #211

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

kavithacm
Copy link
Collaborator

Description

Adding a condition to check if the date Field is included in the selected fields

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a test case for this?

@kavithacm
Copy link
Collaborator Author

could you add a test case for this?

Sure, i'll add it in future PR

@kavithacm kavithacm merged commit 8a9ac2f into opensearch-project:2.11 Oct 11, 2023
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 11, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
(cherry picked from commit 8a9ac2f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.10 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-reporting/backport-2.10 2.10
# Navigate to the new working tree
pushd ../.worktrees/dashboards-reporting/backport-2.10
# Create a new branch
git switch --create backport/backport-211-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8a9ac2ffa3b0477f6258cb2cd0f82d13b59ef544
# Push it to GitHub
git push --set-upstream origin backport/backport-211-to-2.10
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-reporting/backport-2.10

Then, create a pull request where the base branch is 2.10 and the compare/head branch is backport/backport-211-to-2.10.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 11, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
(cherry picked from commit 8a9ac2f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavithacm pushed a commit that referenced this pull request Oct 11, 2023
(cherry picked from commit 8a9ac2f)

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ps48 ps48 mentioned this pull request Oct 12, 2023
1 task
kavithacm pushed a commit that referenced this pull request Oct 24, 2023
(cherry picked from commit 8a9ac2f)

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.10 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-reporting/backport-2.10 2.10
# Navigate to the new working tree
pushd ../.worktrees/dashboards-reporting/backport-2.10
# Create a new branch
git switch --create backport/backport-211-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8a9ac2ffa3b0477f6258cb2cd0f82d13b59ef544
# Push it to GitHub
git push --set-upstream origin backport/backport-211-to-2.10
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-reporting/backport-2.10

Then, create a pull request where the base branch is 2.10 and the compare/head branch is backport/backport-211-to-2.10.

mengweieric pushed a commit to mengweieric/dashboards-reporting that referenced this pull request Nov 6, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
(cherry picked from commit 8a9ac2f)
@kavithacm kavithacm mentioned this pull request Nov 6, 2023
6 tasks
mengweieric added a commit that referenced this pull request Nov 7, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
(cherry picked from commit 8a9ac2f)

Signed-off-by: Eric Wei <[email protected]>
Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants