Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Notes 2.11.1 #255

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Release Notes 2.11.1 #255

merged 2 commits into from
Nov 27, 2023

Conversation

pjfitzgibbons
Copy link
Contributor

Signed-off-by: Peter Fitzgibbons [email protected]

Description

Release Notes 2.11.1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Fitzgibbons <[email protected]>
Compatible with OpenSearch and OpenSearch Dashboards Version 2.11.0

### Features
Use core navigation instead of hard coding URLs ([#229](https://github.com/opensearch-project/dashboards-reporting/pull/229)) ([#231](https://github.com/opensearch-project/dashboards-reporting/pull/231))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature? In a PATCH release?

https://semver.org/#spec-item-6

Patch version Z (x.y.Z | x > 0) MUST be incremented if only backward compatible bug fixes are introduced. A bug fix is defined as an internal change that fixes incorrect behavior.

Have not all non-bugfix backports been revert?

Copy link
Collaborator

@anirudha anirudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review features


Compatible with OpenSearch and OpenSearch Dashboards Version 2.11.0

### Features
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjfitzgibbons can you cross check/ this looks like a maintainence or bug fix / not a feature

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct, #229 fixes #227. Not a feature.

#229 is a bugfix, not a feature

Signed-off-by: Peter Fitzgibbons <[email protected]>
@pjfitzgibbons pjfitzgibbons merged commit 3a025fb into 2.11 Nov 27, 2023
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants