Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] Add single version flag during bootstrap to fix version conflicts #303

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

RyanL1997
Copy link
Contributor

Description

On behalf of the change in dashboards core: opensearch-project/OpenSearch-Dashboards#5675. We need to add --single-version=loose flag during the bootstrap step in our CI to manipulate the behavior of single-version validation.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rupal-bq rupal-bq merged commit 617881a into opensearch-project:main Feb 19, 2024
7 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 19, 2024
Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 617881a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@RyanL1997
Copy link
Contributor Author

Since this one has been merged, we need to add the --single-version=loose flag in dashboards-reports-test-and-build-workflow.yml by PR #299. Including the 2.x backport. (cc: @rupal-bq )

rupal-bq pushed a commit that referenced this pull request Feb 20, 2024
…) (#304)

(cherry picked from commit 617881a)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants