[Manual Backport] Allow arbitrary report record counts #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiddis
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
penghuo,
seankao-az and
anirudha
as code owners
…opensearch-project#395) * feat(components/report-settings): add field for variable record limits Signed-off-by: Károly Szakály <[email protected]> * fix(components/report-settings): set type for event target Signed-off-by: Károly Szakály <[email protected]> * feat(components/report-settings): load existing record limit in edit mode Signed-off-by: Károly Szakály <[email protected]> * feat(components/report-definition-details): show record limit on report definition details page Signed-off-by: Károly Szakály <[email protected]> * feat(components/report-definition-details): omit record limit for non saved search sources Signed-off-by: Károly Szakály <[email protected]> * feat(components/report-details): show record limit on report details page Signed-off-by: Károly Szakály <[email protected]> * tests(cypress): add `force: true` to name input Signed-off-by: Károly Szakály <[email protected]> * tests(jest/snapshots): update snapshots Signed-off-by: Károly Szakály <[email protected]> * feat(components/report-settings): add proper i18n label for record limit input Signed-off-by: Károly Szakály <[email protected]> * Update release notes Signed-off-by: Simeon Widdis <[email protected]> * Add potential OOM warning for large record limits Signed-off-by: Simeon Widdis <[email protected]> * Make memory warning more conservative based on original limit Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Károly Szakály <[email protected]> Signed-off-by: Simeon Widdis <[email protected]> Co-authored-by: Simeon Widdis <[email protected]> Signed-off-by: Simeon Widdis <[email protected]>
6 tasks
joshuali925
reviewed
Sep 9, 2024
public/components/report_definitions/report_settings/report_settings.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Simeon Widdis <[email protected]>
joshuali925
approved these changes
Sep 9, 2024
ps48
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of #395
Issues Resolved
#328
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.