Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for retry settings for Remote reindex #6726

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented Mar 20, 2024

Description

Add documentation for retry settings for Remote reindex

Issues Resolved

Closes #6674

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress release-notes PR: Include this PR in the automated release notes v2.13.0 labels Mar 20, 2024
Signed-off-by: Ankit Kala <[email protected]>
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ankitkala! A couple of suggestions.

_im-plugin/reindex-data.md Outdated Show resolved Hide resolved
_im-plugin/reindex-data.md Outdated Show resolved Hide resolved
_im-plugin/reindex-data.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws self-assigned this Mar 20, 2024
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Ankit Kala <[email protected]>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor nit about "follow," per our discussion. But your call 😄

@ankitkala
Copy link
Member Author

LGTM, with a minor nit about "follow," per our discussion. But your call 😄

Slightly confused here. I did pick all the suggested changes. Is there anything missing?

@kolchfa-aws
Copy link
Collaborator

Let's leave as is per discussion with @natebower. Thanks, @ankitkala. Ready to merge now.

@kolchfa-aws kolchfa-aws merged commit 21a28cf into opensearch-project:main Mar 20, 2024
3 checks passed
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 4 - Doc review PR: Doc review in progress labels Mar 20, 2024
CaptainDredge pushed a commit to CaptainDredge/documentation-website that referenced this pull request Mar 22, 2024
…roject#6726)

* Add documentation for retry settings for Remote reindex

Signed-off-by: Ankit Kala <[email protected]>

* Fixing the typo

Signed-off-by: Ankit Kala <[email protected]>

* Addressing PR comments

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Ankit Kala <[email protected]>

---------

Signed-off-by: Ankit Kala <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add documentation for retry settings for Remote reindex
4 participants