Add qa model and new settings in ml-commons #6749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbhavna
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable and
stephen-crawford
as code owners
Signed-off-by: Bhavana Ramaram <[email protected]>
rbhavna
changed the title
hdhalter
added
release-notes
hdhalter
changed the title
Signed-off-by: Bhavana Ramaram <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
natebower
reviewed
Mar 25, 2024
There was a problem hiding this comment.
@rbhavna @kolchfa-aws Please see my comments and changes and let me know if you have any questions. Thanks!
| - Default value: `true` | ||
| - Valid values: `false`, `true` | ||
|
|
||
| ## Remote model eligible node roles |
There was a problem hiding this comment.
"Eligible node roles for remote models"?
| - Default value: `["data", "ml"]`, which allows externally hosted models to run on data nodes and ML nodes. | ||
|
|
||
|
|
||
| ## Local model eligible node roles setting |
There was a problem hiding this comment.
"Eligible node roles setting for local models"?
| Running local models on the CentOS 7 operating system is not supported. Moreover, not all local models can run on all hardware and operating systems. | ||
| {: .important} | ||
|
|
||
| ## Preparing a model | ||
|
|
||
| For both text embedding and sparse encoding models, you must provide a tokenizer JSON file within the model zip file. | ||
| For all the models, you must provide a tokenizer JSON file within the model zip file. |
There was a problem hiding this comment.
I don't think zip file should be capitalized.
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
kolchfa-aws
reviewed
Mar 25, 2024
kolchfa-aws
reviewed
Mar 25, 2024
Signed-off-by: kolchfa-aws <[email protected]>
kolchfa-aws
approved these changes
Mar 25, 2024
hdhalter
added
3 - Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add qa model and new settings documentation in ml-commons
Issues Resolved
Closes #6744
Closes #6752
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.