Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit for redundant information and sections across Data Prepper #7127
Edit for redundant information and sections across Data Prepper #7127
Changes from 24 commits
16b2387
584e08d
458079e
92cd1b8
7228bb2
c2d751f
82373d7
26c2013
050292a
01b54ac
fe74f47
eb38891
1cb7fb6
50b5161
940bdf3
1ba7767
1e0b30a
a5ae73e
6c37337
e279143
79d8a34
b47b8b4
c647da6
365fa7d
1d735a6
e0f7743
1b1f1f1
36bf8b8
be987b5
83b4136
6bd246f
475e202
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 9 in _data-prepper/pipelines/cidrcontains.md
GitHub Actions / vale
[vale] _data-prepper/pipelines/cidrcontains.md#L9
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there's an unresolved comment/placeholder here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlvenable - Are there alternatives besides what's listed (bounded blocking and kafka) that we can point to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those two are the only buffers currently supported. It may make sense to link to: https://opensearch.org/docs/latest/data-prepper/pipelines/configuration/buffers/buffers/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the buffer.md page, lol. I'll remove the line for now, until we can point to somewhere that describes how to configure alternative types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"under" => "for"?
Check failure on line 9 in _data-prepper/pipelines/contains.md
GitHub Actions / vale
[vale] _data-prepper/pipelines/contains.md#L9
Raw output