Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace analytics update #7362
Trace analytics update #7362
Changes from 62 commits
93516cf
2615a67
49c42c0
f311e7d
cfcec50
1cfd6ff
272d5ee
c78a878
569da98
c08bc63
588620d
7ff2e0f
e7f32c9
10f5bc5
4c87982
aab2347
25e7bc1
1e0e1c7
b2960ed
72d0d9e
b00b006
393e2e1
1521795
0e59e6d
1f4b111
2de6d49
a392b63
9ee3d81
70e321f
95a01cf
6d3f9a4
01aaf20
af81b46
a0e0764
0832eb1
1a4ed0a
c0fed9f
22a6bf1
59cb066
4556fa3
66e88ec
97244d1
6f9cd44
8d72dbf
ea35cc0
41e87e3
7233f31
fb5903a
08c4b4a
214a707
622d796
dfa57f0
83ef1f3
edc0f18
31888a1
41b1a78
9bbd084
a51d01b
9f3beb2
1cc94d6
11b9c58
b7b12f0
3c0ddab
9e59974
59e9e7e
22fd303
5509571
0018777
6cc7072
e5e42bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there should be a "the" preceding "OpenSearch".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think so...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repo name is "OpenTelemetry Demo with OpenSearch."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"rate" => "rates"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be singular
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "business functional unit" the best wording for what we mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so - any suggestions ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Business functional unit refers to the logical grouping of functionality based on the applications purpose. For example, HTTP APIs differ for the application, such as bank application, e-commerce application, or health system application.