Add validate API #7390
Merged
Add validate API #7390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archer <[email protected]>
Signed-off-by: Archer <[email protected]>
Signed-off-by: Archer <[email protected]>
Naarcha-AWS
requested review from
hdhalter,
kolchfa-aws,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
Naarcha-AWS
added
3 - Tech review
Signed-off-by: Naarcha-AWS <[email protected]>
|
@msfroh: Would you mind performing a tech review on this one? |
|
@gbbafna: Can you take a look at this one? |
Naarcha-AWS
commented
Jul 15, 2024
Naarcha-AWS
commented
Jul 15, 2024
Signed-off-by: Naarcha-AWS <[email protected]>
hdhalter
previously requested changes
Jul 23, 2024
Co-authored-by: Heather Halter <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
commented
Jul 23, 2024
Naarcha-AWS
commented
Jul 23, 2024
Naarcha-AWS
commented
Aug 21, 2024
Naarcha-AWS
commented
Aug 21, 2024
Naarcha-AWS
commented
Aug 21, 2024
Naarcha-AWS
commented
Aug 21, 2024
Naarcha-AWS
added
5 - Editorial review
natebower
reviewed
Aug 22, 2024
There was a problem hiding this comment.
@Naarcha-AWS Can you resolve the remaining comments and tag me when ready? Thanks!
Signed-off-by: Naarcha-AWS <[email protected]>
|
@natebower: Resolved. |
natebower
requested changes
Aug 22, 2024
There was a problem hiding this comment.
@Naarcha-AWS Please see my comments and changes and tag me for a reread/approval when addressed. Thanks!
Naarcha-AWS
commented
Aug 22, 2024
Naarcha-AWS
commented
Aug 22, 2024
Naarcha-AWS
commented
Aug 22, 2024
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
commented
Aug 22, 2024
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
|
@natebower: This should be ready for your approval. |
natebower
approved these changes
Aug 22, 2024
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Add validate API. Signed-off-by: Archer <[email protected]> * Add detailed responses Signed-off-by: Archer <[email protected]> * Add working request and response examples Signed-off-by: Archer <[email protected]> * Update validate.md Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Heather Halter <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Update validate.md Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Update _api-reference/validate.md Signed-off-by: Naarcha-AWS <[email protected]> * Update _api-reference/validate.md Signed-off-by: Naarcha-AWS <[email protected]> * Update _api-reference/validate.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Update _api-reference/validate.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Archer <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 34b0276) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Add validate API. Signed-off-by: Archer <[email protected]> * Add detailed responses Signed-off-by: Archer <[email protected]> * Add working request and response examples Signed-off-by: Archer <[email protected]> * Update validate.md Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Heather Halter <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Update validate.md Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Update _api-reference/validate.md Signed-off-by: Naarcha-AWS <[email protected]> * Update _api-reference/validate.md Signed-off-by: Naarcha-AWS <[email protected]> * Update _api-reference/validate.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Update _api-reference/validate.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Archer <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 34b0276) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Resolved
Closes #2104
Version
List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.