-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resolve API #7603
base: main
Are you sure you want to change the base?
Add Resolve API #7603
Conversation
Signed-off-by: Archer <[email protected]>
@gbbafna: Can you take a look at this one? |
Want to try and author a working test for this in https://github.com/opensearch-project/opensearch-api-specification/tree/main/tests/indices similar to https://github.com/opensearch-project/opensearch-api-specification/blob/main/tests/indices/flush.yaml for example? If you need a data stream, copy from https://github.com/opensearch-project/opensearch-api-specification/blob/main/tests/indices/data_stream.yaml. |
I'll give it a try. |
Signed-off-by: Naarcha-AWS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few suggestions.
|
||
## Path and HTTP methods | ||
|
||
The Resolve Index API supports the following API method: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this line? We don't have an intro sentence in the template.
## Permissions | ||
|
||
When OpenSearch Security is enabled, you must have the `view_index_metadata` or `manage` index permissions for the target data stream, index, or index alias. <!-----FOLLOW UP, Is there a distinction between index permissions and index privileges?> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we link to the permissions page?
Co-authored-by: Heather Halter <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
Closes #2114
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.